From: Roman Gushchin <roman.gushchin-fxUVXftIFDnyG1zEObXtfA@public.gmane.org>
To: David Vernet <void-gq6j2QGBifHby3iVrkZq2A@public.gmane.org>
Cc: akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org,
mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
kernel-team-b10kYP2dOMg@public.gmane.org
Subject: Re: [PATCH 1/5] cgroups: Refactor children cgroups in memcg tests
Date: Fri, 22 Apr 2022 16:04:15 -0700 [thread overview]
Message-ID: <YmM0b+3thMZaXVDb@carbon> (raw)
In-Reply-To: <20220422155728.3055914-2-void-gq6j2QGBifHby3iVrkZq2A@public.gmane.org>
On Fri, Apr 22, 2022 at 08:57:25AM -0700, David Vernet wrote:
> In test_memcg_min() and test_memcg_low(), there is an array of four sibling
> cgroups. All but one of these sibling groups does a 50MB allocation, and
> the group that does no allocation is the third of four in the array. This
> is not a problem per se, but makes it a bit tricky to do some assertions in
> test_memcg_low(), as we want to make assertions on the siblings based on
> whether or not they performed allocations. Having a static index before
> which all groups have performed an allocation makes this cleaner.
>
> This patch therefore reorders the sibling groups so that the group that
> performs no allocations is the last in the array.
It makes the comment explaining the test just above the test_memcg_min()
function obsolete. Please, fix it too.
Thanks!
next prev parent reply other threads:[~2022-04-22 23:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 15:57 [PATCH 0/5] Fix bugs in memcontroller cgroup tests David Vernet
[not found] ` <20220422155728.3055914-1-void-gq6j2QGBifHby3iVrkZq2A@public.gmane.org>
2022-04-22 15:57 ` [PATCH 1/5] cgroups: Refactor children cgroups in memcg tests David Vernet
[not found] ` <20220422155728.3055914-2-void-gq6j2QGBifHby3iVrkZq2A@public.gmane.org>
2022-04-22 23:04 ` Roman Gushchin [this message]
2022-04-23 11:30 ` David Vernet
[not found] ` <20220423113037.gnfysktiuzmfnpmp-2sxDN0k4oOr/D8ZFBB3Vemm1Eemhq0z/AL8bYrjMMd8@public.gmane.org>
2022-04-23 15:19 ` Roman Gushchin
[not found] ` <EEC47283-0467-4C97-AAB2-73F17A97CE15-fxUVXftIFDnyG1zEObXtfA@public.gmane.org>
2022-04-23 15:33 ` David Vernet
2022-04-22 15:57 ` [PATCH 2/5] cgroup: Account for memory_recursiveprot in test_memcg_low() David Vernet
[not found] ` <20220422155728.3055914-3-void-gq6j2QGBifHby3iVrkZq2A@public.gmane.org>
2022-04-22 23:06 ` Roman Gushchin
2022-04-23 11:33 ` David Vernet
2022-04-22 15:57 ` [PATCH 3/5] cgroup: Account for memory_localevents in test_memcg_oom_group_leaf_events() David Vernet
[not found] ` <20220422155728.3055914-4-void-gq6j2QGBifHby3iVrkZq2A@public.gmane.org>
2022-04-22 23:14 ` Roman Gushchin
2022-04-23 11:36 ` David Vernet
2022-04-22 15:57 ` [PATCH 4/5] cgroup: Removing racy check in test_memcg_sock() David Vernet
[not found] ` <20220422155728.3055914-5-void-gq6j2QGBifHby3iVrkZq2A@public.gmane.org>
2022-04-22 23:50 ` Roman Gushchin
2022-04-23 11:50 ` David Vernet
2022-04-22 15:57 ` [PATCH 5/5] cgroup: Fix racy check in alloc_pagecache_max_30M() helper function David Vernet
[not found] ` <20220422155728.3055914-6-void-gq6j2QGBifHby3iVrkZq2A@public.gmane.org>
2022-04-22 23:56 ` Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmM0b+3thMZaXVDb@carbon \
--to=roman.gushchin-fxuvxftifdnyg1zeobxtfa@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
--cc=kernel-team-b10kYP2dOMg@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=void-gq6j2QGBifHby3iVrkZq2A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox