From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Weiner Subject: Re: [PATCH 4/5] mm: zswap: add basic meminfo and vmstat coverage Date: Thu, 28 Apr 2022 13:27:46 -0400 Message-ID: References: <20220427160016.144237-1-hannes@cmpxchg.org> <20220427160016.144237-5-hannes@cmpxchg.org> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ywIQvVwgag1com6bDxPqmKMeB7A08MtYuevMsyOSOPQ=; b=8QDJnLhAmNHGsLaBQmDqBrcILYyDP9jv4WD9nDDyluZQ3AyEx3MdCGQSDqxW70SGO6 dHjEacPn670Cttc+vma5fsmybXQrEWDwOSriDm4M1zh/p8R0cfGR+P2UeAOOswBdPoPN UymIxmq005YN0pWaKnhy3Qt5T8fMP40inSpO/g4yKZyoeuGW2l3pub90YoPGUGQkiuLX cmUr1lNoAFW3vWIR6Ju6NmnMFVQlilVHADUJd9/Hwy6MK77xIUrA6Iyos41ScIK3y026 cbYAaiaMgarYe1E4TgstRbzWse+RFycZstcjBiJwinrr2bYwiHSWcfz1tz0VoDWKMy1B frzg== Content-Disposition: inline In-Reply-To: List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Minchan Kim Cc: Andrew Morton , Michal Hocko , Roman Gushchin , Shakeel Butt , Seth Jennings , Dan Streetman , linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-team-b10kYP2dOMg@public.gmane.org On Thu, Apr 28, 2022 at 10:02:46AM -0700, Minchan Kim wrote: > On Thu, Apr 28, 2022 at 10:05:13AM -0400, Johannes Weiner wrote: > > But I'd ack a patch that adds a combined "Compressed" counter for zram > > + zswap if you send it, Minchan. > > If we really want to go separate stat for zswap and zram, it would > be better to use direct name "Zram: " instead of comrpessed. That works for me as well.