public inbox for cgroups@vger.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: xiujianfeng <xiujianfeng-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Cc: lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org,
	hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH -next] cgroup: Make cgroup_debug static
Date: Wed, 18 May 2022 06:57:13 -1000	[thread overview]
Message-ID: <YoUlaTQrEf+NxINS@slm.duckdns.org> (raw)
In-Reply-To: <c099059c-2953-232d-3d53-e8863c221cb0-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>

On Wed, May 18, 2022 at 02:48:36PM +0800, xiujianfeng wrote:
> 
> 在 2022/5/18 1:06, Tejun Heo 写道:
> > On Tue, May 17, 2022 at 07:25:23PM +0800, Xiu Jianfeng wrote:
> > > Make cgroup_debug static since it's only used in cgroup.c
> > > 
> > > Signed-off-by: Xiu Jianfeng <xiujianfeng-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
> > The only thing it does is gating CFTYPE_DEBUG which isn't used anymore.
> > Can you remove both CFTYPE_DEBUG and cgroup_debug() instead?
> 
> It's ok to me, but I found CFTYPE_DEBUG is still used in cpuset subsys,
> 
>   .name = "cpus.subpartitions",
>   .seq_show = cpuset_common_seq_show,
>   .private = FILE_SUBPARTS_CPULIST,
>   .flags = CFTYPE_DEBUG,
> 
> if remove CFTYPE_DEBUG and cgroup_debug,  cpus.subpartitions will be showed
> by default,  is this ok?

Ah, I missed that. You're right. Lemme apply the original path.

Thanks.

-- 
tejun

  parent reply	other threads:[~2022-05-18 16:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-17 11:25 [PATCH -next] cgroup: Make cgroup_debug static Xiu Jianfeng
     [not found] ` <20220517112523.243386-1-xiujianfeng-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2022-05-17 17:06   ` Tejun Heo
     [not found]     ` <YoPWJZ+RJmlvBLwV-NiLfg/pYEd1N0TnZuCh8vA@public.gmane.org>
2022-05-18  6:48       ` xiujianfeng
     [not found]         ` <c099059c-2953-232d-3d53-e8863c221cb0-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2022-05-18 16:57           ` Tejun Heo [this message]
2022-05-18 17:03 ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YoUlaTQrEf+NxINS@slm.duckdns.org \
    --to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org \
    --cc=xiujianfeng-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox