public inbox for cgroups@vger.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Hongchen Zhang <zhanghongchen-cXZgJK919ebM1kAEIRd3EQ@public.gmane.org>
Cc: Zefan Li <lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org>,
	Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] cgroup: wait for css offline when rmdir
Date: Tue, 31 May 2022 07:22:35 -1000	[thread overview]
Message-ID: <YpZO26mJ3Wm0AeHo@slm.duckdns.org> (raw)
In-Reply-To: <YpZOIz/CbQs+aWF6-NiLfg/pYEd1N0TnZuCh8vA@public.gmane.org>

On Tue, May 31, 2022 at 07:19:31AM -1000, Tejun Heo wrote:
> Maybe just keep the sequence numbers for started and completed offline
> operations and wait for completed# to reach the started# on memcg alloc
> failure and retry? Note that we can get live locked, so have to remember the
> sequence number to wait for at the beginning. Or, even simpler, maybe it'd
> be enough to just do synchronize_rcu() and then wait for the offline wait
> once and retry.

Also, given that it's an memcg ID issue. It probably makes sense to
implement it on the memcg side.

Thanks.

-- 
tejun

      parent reply	other threads:[~2022-05-31 17:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-27  2:39 [PATCH] cgroup: wait for css offline when rmdir Hongchen Zhang
     [not found] ` <1653619158-27607-1-git-send-email-zhanghongchen-cXZgJK919ebM1kAEIRd3EQ@public.gmane.org>
2022-05-27  8:46   ` kernel test robot
2022-05-27  8:48   ` Tejun Heo
2022-05-30  1:53     ` Hongchen Zhang
     [not found]       ` <e74e03f1-cb54-b158-a085-2965fd088d1d-cXZgJK919ebM1kAEIRd3EQ@public.gmane.org>
2022-05-31  1:01         ` Tejun Heo
     [not found]           ` <YpVo4XiIDu68w40Z-NiLfg/pYEd1N0TnZuCh8vA@public.gmane.org>
2022-05-31  3:49             ` Hongchen Zhang
     [not found]               ` <fbb820c5-dbcb-0f00-c365-d3c57ca27edf-cXZgJK919ebM1kAEIRd3EQ@public.gmane.org>
2022-05-31 17:19                 ` Tejun Heo
     [not found]                   ` <YpZOIz/CbQs+aWF6-NiLfg/pYEd1N0TnZuCh8vA@public.gmane.org>
2022-05-31 17:22                     ` Tejun Heo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YpZO26mJ3Wm0AeHo@slm.duckdns.org \
    --to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org \
    --cc=zhanghongchen-cXZgJK919ebM1kAEIRd3EQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox