From: Ming Lei <ming.lei-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Waiman Long <longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Jens Axboe <axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v6 2/3] blk-cgroup: Return -ENOMEM directly in blkcg_css_alloc() error path
Date: Sat, 4 Jun 2022 10:16:19 +0800 [thread overview]
Message-ID: <YprAc9uLaDPXUW2s@T590> (raw)
In-Reply-To: <20220602192020.166940-3-longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
On Thu, Jun 02, 2022 at 03:20:19PM -0400, Waiman Long wrote:
> For blkcg_css_alloc(), the only error that will be returned is -ENOMEM.
> Simplify error handling code by returning this error directly instead
> of setting an intermediate "ret" variable.
>
> Signed-off-by: Waiman Long <longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Looks fine:
Reviewed-by: Ming Lei <ming.lei-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Thanks,
Ming
next prev parent reply other threads:[~2022-06-04 2:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-02 19:20 [PATCH v6 0/3] blk-cgroup: Optimize blkcg_rstat_flush() Waiman Long
[not found] ` <20220602192020.166940-1-longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2022-06-02 19:20 ` [PATCH v6 1/3] blk-cgroup: Correctly free percpu iostat_cpu in blkg on error exit Waiman Long
[not found] ` <20220602192020.166940-2-longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2022-06-04 2:08 ` Ming Lei
2022-06-04 2:47 ` Waiman Long
2022-06-02 19:20 ` [PATCH v6 2/3] blk-cgroup: Return -ENOMEM directly in blkcg_css_alloc() error path Waiman Long
2022-06-02 20:39 ` Tejun Heo
[not found] ` <20220602192020.166940-3-longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2022-06-04 2:16 ` Ming Lei [this message]
2022-06-02 19:20 ` [PATCH v6 3/3] blk-cgroup: Optimize blkcg_rstat_flush() Waiman Long
2022-06-04 3:58 ` Ming Lei
2022-06-05 23:15 ` Waiman Long
2022-06-06 1:39 ` Ming Lei
2022-06-06 1:59 ` Waiman Long
2022-06-06 2:23 ` Ming Lei
2022-06-06 2:58 ` Waiman Long
2022-06-06 3:15 ` Ming Lei
[not found] ` <20220602192020.166940-4-longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2022-06-06 3:16 ` Ming Lei
2022-06-08 16:57 ` Michal Koutný
2022-06-08 18:16 ` Waiman Long
2022-06-08 21:12 ` Michal Koutný
2022-06-08 22:14 ` Michal Koutný
2022-09-30 18:34 ` Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YprAc9uLaDPXUW2s@T590 \
--to=ming.lei-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox