public inbox for cgroups@vger.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Feng Tang <feng.tang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: Zefan Li <lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org>,
	Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] cgroup: cleanup the format of /proc/cgroups
Date: Sun, 21 Aug 2022 21:30:28 -1000	[thread overview]
Message-ID: <YwMwlMv/tK3sRXbB@slm.duckdns.org> (raw)
In-Reply-To: <20220821073446.92669-1-feng.tang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

Hello,

On Sun, Aug 21, 2022 at 03:34:46PM +0800, Feng Tang wrote:
> Currrent /proc/cgroup output is like:
> 
>   #subsys_name	hierarchy	num_cgroups	enabled
>   cpuset	6	1	1
>   cpu	4	7	1
>   cpuacct	4	7	1
>   blkio	8	7	1
>   memory	9	7	1
>   ...
> 
> Add some indentation to make it more readable without any functional
> change:

So, this has been suggested a couple times before and I fully agree that the
file is really ugly. In the past, we didn't pull the trigger on it for two
reasons - 1. It is user-visible functional change in that it can break
really dumb parsers 2. the file is only useful for cgroup1 which has been in
mostly maintenance mode for many years now. I don't feel that strongly
either way but still kinda lean towards just leaving it as-is.

Thanks.

-- 
tejun

  parent reply	other threads:[~2022-08-22  7:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-21  7:34 [PATCH] cgroup: cleanup the format of /proc/cgroups Feng Tang
     [not found] ` <20220821073446.92669-1-feng.tang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2022-08-22  7:30   ` Tejun Heo [this message]
     [not found]     ` <YwMwlMv/tK3sRXbB-NiLfg/pYEd1N0TnZuCh8vA@public.gmane.org>
2022-08-22  7:52       ` Feng Tang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YwMwlMv/tK3sRXbB@slm.duckdns.org \
    --to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=feng.tang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
    --cc=lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox