From: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
To: Zhaoyang Huang <huangzhaoyang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Michal Hocko <mhocko-IBi9RG/b67k@public.gmane.org>,
Suren Baghdasaryan
<surenb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Shakeel Butt <shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
"zhaoyang.huang"
<zhaoyang.huang-1tVvrHeaX6nQT0dZR+AlfA@public.gmane.org>,
Linux MM <linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org>,
LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Cgroups <cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Ke Wang <ke.wang-1tVvrHeaX6nQT0dZR+AlfA@public.gmane.org>,
Zefan Li <lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org>,
Roman Gushchin
<roman.gushchin-fxUVXftIFDnyG1zEObXtfA@public.gmane.org>,
Muchun Song <songmuchun-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org>
Subject: Re: [RFC PATCH] memcg: use root_mem_cgroup when css is inherited
Date: Thu, 25 Aug 2022 09:35:00 -0400 [thread overview]
Message-ID: <Ywd6hN1Q9MtQWZCp@cmpxchg.org> (raw)
In-Reply-To: <CAGWkznHL_G3OoAc5gJ+iwxqxonr21-fU+F4T2gkpXH68keLpuQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Thu, Aug 25, 2022 at 06:11:09PM +0800, Zhaoyang Huang wrote:
> Sorry for any misunderstanding among the discussion. My purpose is
> real and simple as I have stated from the very beginning that I would
> like to have per-app cgroup hierarchy to charge memory to root if it
> is not enabled explicitly for memory. The reason has also been stated
> like reclaim and workingset regression in suren's report. I don't
> think my proposal will do any harm to current v2's mechanism besides
> asking for the admin echo "+memory" to their desire group.
It would permit children to escape parental control, completely
breaking the hierarchy and delegation guarantees currently in
place. That just isn't going to happen.
Nacked-by: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
I would suggest focusing on finding the root cause for the reclaim
problem you are describing. It's possible all we need is a fix to
reclaim or the workingset code.
prev parent reply other threads:[~2022-08-25 13:35 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-19 11:29 [RFC PATCH] memcg: use root_mem_cgroup when css is inherited zhaoyang.huang
[not found] ` <1660908562-17409-1-git-send-email-zhaoyang.huang-1tVvrHeaX6nQT0dZR+AlfA@public.gmane.org>
2022-08-19 16:29 ` Tejun Heo
[not found] ` <Yv+6YjaGAv52yvq9-NiLfg/pYEd1N0TnZuCh8vA@public.gmane.org>
2022-08-19 17:08 ` Shakeel Butt
[not found] ` <CALvZod7QdLSMdBoD2WztL72qS8kJe7F79JuCH6t19rRcw6Pn1w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2022-08-19 17:10 ` Tejun Heo
[not found] ` <Yv/EArPDTcCrGqJh-NiLfg/pYEd1N0TnZuCh8vA@public.gmane.org>
2022-08-22 11:31 ` Michal Hocko
2022-08-23 2:31 ` Zhaoyang Huang
[not found] ` <CAGWkznEB+R0YBaBFBL7dPqs8R=qKC6+ixTWEGCYy2PaczXkaPA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2022-08-23 5:21 ` Michal Hocko
[not found] ` <YwRjyx6wFLk8WTDe-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2022-08-23 6:03 ` Zhaoyang Huang
[not found] ` <CAGWkznGaYTv4u4kOo-rupfyWzDNJXNKTchwP6dbUK-=UXWm47w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2022-08-23 8:33 ` Michal Hocko
[not found] ` <YwSQ4APOu/H7lYGL-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2022-08-23 9:20 ` Zhaoyang Huang
[not found] ` <CAGWkznGd6mgareABseMKY5p0f1=5dkfVkj=NS7_B6OkXBYSwyw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2022-08-23 11:51 ` Michal Hocko
[not found] ` <YwS/S9Sd1OWnT81Q-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2022-08-23 16:21 ` Suren Baghdasaryan
[not found] ` <CAJuCfpH+T9+eOVYDfOv9yNSfAvq=pJtMp4ZaoYaM7iMY9XkaUw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2022-08-24 7:59 ` Michal Hocko
[not found] ` <YwXaXHRhy51xH4rk-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2022-08-24 17:13 ` Suren Baghdasaryan
2022-08-24 2:23 ` Zhaoyang Huang
[not found] ` <CAGWkznGYLyF+njUB0gFF3JVdThnK9JaNsqxXYFhbdSwEQpCxvA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2022-08-24 7:50 ` Michal Hocko
[not found] ` <YwXYVjRpXQjQMsxr-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2022-08-24 9:34 ` Zhaoyang Huang
[not found] ` <CAGWkznEqX3DwHW_owiK+HuuQ-HsUYK4vKmLhSxgzGn20Vzid2A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2022-08-24 10:27 ` Michal Hocko
[not found] ` <YwX89JCQCKMMYdG9-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2022-08-25 0:43 ` Zhaoyang Huang
[not found] ` <CAGWkznF+dBjLzAxMMXWYSZ_5q3KA-ou0P7XM7jSYN7JSRp8N0w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2022-08-25 6:40 ` Michal Hocko
[not found] ` <YwcZctA2S3Sd0LBN-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2022-08-25 8:34 ` Zhaoyang Huang
2022-08-25 8:50 ` Michal Hocko
[not found] ` <Ywc34ci5XUMXOSYA-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2022-08-25 10:11 ` Zhaoyang Huang
[not found] ` <CAGWkznHL_G3OoAc5gJ+iwxqxonr21-fU+F4T2gkpXH68keLpuQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2022-08-25 13:35 ` Johannes Weiner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ywd6hN1Q9MtQWZCp@cmpxchg.org \
--to=hannes-druugvl0lcnafugrpc6u6w@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=huangzhaoyang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=ke.wang-1tVvrHeaX6nQT0dZR+AlfA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org \
--cc=mhocko-IBi9RG/b67k@public.gmane.org \
--cc=roman.gushchin-fxUVXftIFDnyG1zEObXtfA@public.gmane.org \
--cc=shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=songmuchun-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org \
--cc=surenb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=zhaoyang.huang-1tVvrHeaX6nQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox