From mboxrd@z Thu Jan  1 00:00:00 1970
From: Petr Mladek <pmladek@suse.com>
Subject: Re: [PATCH] kernel: move from strlcpy with unused retval to strscpy
Date: Thu, 25 Aug 2022 11:27:46 +0200
Message-ID: <YwdAknZFyKxCXZuL@alley>
References: <20220818210202.8227-1-wsa+renesas@sang-engineering.com>
Mime-Version: 1.0
Return-path: <bpf-owner@vger.kernel.org>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
        t=1661419669; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
         mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=oD2ON5ZEmElLgT4EBxpSWyu1ku5LP4DrXwfA23XWjH4=;
        b=qknJkW1fP0r2UL8UgzODME4WEr79d6P4xEuqkMLZADrhrnaZvBgIbr/L0faRbdiu6dHJmE
        tvkb1ptlffg/lhWil1eQZUDjhGa6bN1dyT5LO7aJKLLNCh/XcrNqoiWnPzH6p5mvmmoUDQ
        3JAdcgDNBV8/4sIoa7uVLdV0TcindVs=
Content-Disposition: inline
In-Reply-To: <20220818210202.8227-1-wsa+renesas@sang-engineering.com>
List-ID: <cgroups.vger.kernel.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-kernel@vger.kernel.org, Alexei Starovoitov <ast@kernel.org>, Daniel Borkmann <daniel@iogearbox.net>, Andrii Nakryiko <andrii@kernel.org>, Martin KaFai Lau <martin.lau@linux.dev>, Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>, John Fastabend <john.fastabend@gmail.com>, KP Singh <kpsingh@kernel.org>, Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>, Jiri Olsa <jolsa@kernel.org>, Tejun Heo <tj@kernel.org>, Zefan Li <lizefan.x@bytedance.com>, Johannes Weiner <hannes@cmpxchg.org>, Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>, Arnaldo Carvalho de Melo <acme@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Alexander Shishkin <alexander.shishkin@linux.intel.com>, Namhyung Kim <namhyung@kernel.org>, Ser

On Thu 2022-08-18 23:02:01, Wolfram Sang wrote:
> Follow the advice of the below link and prefer 'strscpy' in this
> subsystem. Conversion is 1:1 because the return value is not used.
> Generated by a coccinelle script.
> 
> Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> ---
>  kernel/acct.c                         |  2 +-
>  kernel/bpf/preload/bpf_preload_kern.c |  4 ++--
>  kernel/cgroup/cgroup-v1.c             |  4 ++--
>  kernel/events/core.c                  |  6 +++---
>  kernel/kallsyms.c                     |  4 ++--
>  kernel/params.c                       |  2 +-
>  kernel/printk/printk.c                |  2 +-
>  kernel/relay.c                        |  4 ++--
>  kernel/time/clocksource.c             |  2 +-
>  kernel/trace/ftrace.c                 | 18 +++++++++---------
>  kernel/trace/trace.c                  |  8 ++++----
>  kernel/trace/trace_events.c           |  2 +-
>  kernel/trace/trace_events_inject.c    |  4 ++--
>  kernel/trace/trace_kprobe.c           |  2 +-
>  kernel/trace/trace_probe.c            |  2 +-
>  15 files changed, 33 insertions(+), 33 deletions(-)

This fixes only small part of the kernel code. It would make sense to
do a tree-wide change using a script.

Would you mind to create one and send it to Linus?

You might want to use Coccinelle if a simple sed/awk gets too
complicated. See
https://www.kernel.org/doc/html/v4.15/dev-tools/coccinelle.html

Best Regards,
Petr