Re: [PATCH v2 cgroup/for-5.20] cgroup: Replace cgroup->ancestor_ids[] with ->ancestors[]

Tejun Heo
2022-07-29T23:02:10Z

On Sat, Jul 30, 2022 at 12:42:09AM +0200, Michal Koutný wrote:
> On Fri, Jul 29, 2022 at 10:58:22AM -1000, Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> > @@ -520,8 +520,8 @@ struct cgroup_root {
> > /* The root cgroup. Root is destroyed on its release. */
> > struct cgroup cgrp;
> >
> > - /* for cgrp->ancestor_ids[0] */
> > - u64 cgrp_ancestor_id_storage;
> > + /* for cgrp->ancestors[0] */
> > + u64 cgrp_ancestor_storage;
>
> Just noticed, this member is (and was AFAICS) superfluous.

I should have changed the type to struct cgroup * but that's the space into
which cgroup_root->cgrp->ancestors[] stretch into.

Thanks.

--
tejun