public inbox for cgroups@vger.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Waiman Long <longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: "Jens Axboe" <axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	"Ming Lei" <ming.lei-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	"Andy Shevchenko"
	<andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
	"Andrew Morton"
	<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
	"Michal Koutný" <mkoutny-IBi9RG/b67k@public.gmane.org>
Subject: Re: [PATCH v7 1/3] llist: Add a lock-less list variant terminated by a sentinel node
Date: Mon, 3 Oct 2022 06:57:37 -1000	[thread overview]
Message-ID: <YzsUgY4CC0SH8Sl2@slm.duckdns.org> (raw)
In-Reply-To: <006ebc52-ab37-442a-9ba3-e7b8dff53fab-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

On Mon, Oct 03, 2022 at 12:55:24PM -0400, Waiman Long wrote:
> That was my original plan. However, after looking at some existing users of
> lockless list, they have coded in the dependency on the fact that a lockless
> list is empty if it is NULL. I guess I can make this true also for the new
> lockless list with sentinel at the expense of a bit more overhead in the
> entry insertion path and deletion path. I will take a further look at that.

There aren't that many users of llist. Maybe it'd be easier / cleaner to
introduce a macro to test whether a llist is empty and replace the NULL
tests?

Thanks.

-- 
tejun

  parent reply	other threads:[~2022-10-03 16:57 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-03 15:44 [PATCH v7 0/3] blk-cgroup: Optimize blkcg_rstat_flush() Waiman Long
2022-10-03 15:44 ` [PATCH v7 1/3] llist: Add a lock-less list variant terminated by a sentinel node Waiman Long
     [not found]   ` <20221003154459.207538-2-longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2022-10-03 16:40     ` Tejun Heo
     [not found]       ` <YzsQZPONIJRgtf3o-NiLfg/pYEd1N0TnZuCh8vA@public.gmane.org>
2022-10-03 16:55         ` Waiman Long
     [not found]           ` <006ebc52-ab37-442a-9ba3-e7b8dff53fab-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2022-10-03 16:57             ` Tejun Heo [this message]
     [not found]               ` <YzsUgY4CC0SH8Sl2-NiLfg/pYEd1N0TnZuCh8vA@public.gmane.org>
2022-10-03 17:32                 ` Waiman Long
2022-10-03 17:36                   ` Tejun Heo
2022-10-03 17:40                     ` Waiman Long
     [not found]                       ` <87e7cd70-4ab6-f33b-ce26-afe2c7c04faa-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2022-10-03 19:39                         ` Waiman Long
     [not found]                           ` <67f5d0af-dbfa-291a-a596-c90860b94455-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2022-10-03 20:15                             ` Tejun Heo
2022-10-08  2:15   ` Huang, Ying
2022-10-03 15:44 ` [PATCH v7 2/3] blk-cgroup: Return -ENOMEM directly in blkcg_css_alloc() error path Waiman Long
2022-10-03 16:40   ` Tejun Heo
2022-10-03 15:44 ` [PATCH v7 3/3] blk-cgroup: Optimize blkcg_rstat_flush() Waiman Long

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YzsUgY4CC0SH8Sl2@slm.duckdns.org \
    --to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
    --cc=andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    --cc=axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=ming.lei-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=mkoutny-IBi9RG/b67k@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox