From: Tejun Heo <tj@kernel.org>
To: Waiman Long <longman@redhat.com>
Cc: "Jens Axboe" <axboe@kernel.dk>,
cgroups@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, "Ming Lei" <ming.lei@redhat.com>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Michal Koutný" <mkoutny@suse.com>
Subject: Re: [PATCH v7 1/3] llist: Add a lock-less list variant terminated by a sentinel node
Date: Mon, 3 Oct 2022 07:36:50 -1000 [thread overview]
Message-ID: <YzsdsjlMMDFwLOzR@slm.duckdns.org> (raw)
In-Reply-To: <8008933b-4a28-19e5-02db-ef1d07eaf952@redhat.com>
Hello,
On Mon, Oct 03, 2022 at 01:32:49PM -0400, Waiman Long wrote:
> What my current thinking is to make llist works with both NULL and sentinel
> terminated lockless list. Users who wish to use the sentinel terminated
> version will have to use special sentinel version of LLIST_HEAD() macro and
> llist_del_all() and __llist_del_all() functions. In this way, I don't need
> to touch an existing users of llist while minimizing code redundancy. What
> do you think?
Wouldn't that be more error-prone in the long term? I'd just bite the bullet
and convert the empty tests. It is a hassle to find them but given that it's
just the head node testing, it hopefully wouldn't be too bad.
Thanks.
--
tejun
next prev parent reply other threads:[~2022-10-03 17:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-03 15:44 [PATCH v7 0/3] blk-cgroup: Optimize blkcg_rstat_flush() Waiman Long
2022-10-03 15:44 ` [PATCH v7 1/3] llist: Add a lock-less list variant terminated by a sentinel node Waiman Long
[not found] ` <20221003154459.207538-2-longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2022-10-03 16:40 ` Tejun Heo
[not found] ` <YzsQZPONIJRgtf3o-NiLfg/pYEd1N0TnZuCh8vA@public.gmane.org>
2022-10-03 16:55 ` Waiman Long
[not found] ` <006ebc52-ab37-442a-9ba3-e7b8dff53fab-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2022-10-03 16:57 ` Tejun Heo
[not found] ` <YzsUgY4CC0SH8Sl2-NiLfg/pYEd1N0TnZuCh8vA@public.gmane.org>
2022-10-03 17:32 ` Waiman Long
2022-10-03 17:36 ` Tejun Heo [this message]
2022-10-03 17:40 ` Waiman Long
[not found] ` <87e7cd70-4ab6-f33b-ce26-afe2c7c04faa-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2022-10-03 19:39 ` Waiman Long
[not found] ` <67f5d0af-dbfa-291a-a596-c90860b94455-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2022-10-03 20:15 ` Tejun Heo
2022-10-08 2:15 ` Huang, Ying
2022-10-03 15:44 ` [PATCH v7 2/3] blk-cgroup: Return -ENOMEM directly in blkcg_css_alloc() error path Waiman Long
2022-10-03 16:40 ` Tejun Heo
2022-10-03 15:44 ` [PATCH v7 3/3] blk-cgroup: Optimize blkcg_rstat_flush() Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzsdsjlMMDFwLOzR@slm.duckdns.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=ming.lei@redhat.com \
--cc=mkoutny@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox