From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C260E207A19 for ; Thu, 13 Feb 2025 06:20:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739427654; cv=none; b=tRhhWktdda9PSmtAZJiNzZmnGMu+nkvCtk0RVMRgL7OICZZPmvVkYZ68qSmiyrcyCoxSBTrxhAhEaQa7DKG2r090/mJ5LcaB1nAoEtDQJ3E7r8C3eRdmU/ZUsJIruS2KJfUBXbxkm1XnouVsVPt9WXMDvtCxwy/KoF+Uw++t3J8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739427654; c=relaxed/simple; bh=ujajjJF3gxYdA1DcNCIqKS9o38/7j0hv1rZ6wwtwKUY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MQ36R7gpm+pJCzIClDnoIet0JXFy3KEpUYMrpifwUUaeChH2kHHF+Ly8HTyQ59c5IaffxAx+bDJAwYJ1uI/GvBeAR/7o2U+aL6xpsQFkV5ffl/SfhOwV8RYEeiSiIunusldr0RO+eZ11rsoqk585AMVcBqUujFa6RYX70il8HlA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=LruLTUyn; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="LruLTUyn" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739427651; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CPPPQaWJNVckUPtigjDkhfhBpenPmQjuRXN55oSVE/w=; b=LruLTUynvdgvYeMAtPo9tiqthxwf4y8WosBYj7W6iSP2KN/r/IauJvyIU1LYGZWVWyRyCW p6AV9ALpYGI/tx4JGl9byO+f7zJJauP61ISa3CvvUDvUEu/y4V6I41L3FhfgzV8ASNTydF 1mc1tCu0TqmW97Z4UDLdjeBooaeINHA= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-661-z3wKDZs_NjGU9BZAPRGOwg-1; Thu, 13 Feb 2025 01:20:50 -0500 X-MC-Unique: z3wKDZs_NjGU9BZAPRGOwg-1 X-Mimecast-MFC-AGG-ID: z3wKDZs_NjGU9BZAPRGOwg Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4395ff90167so2237635e9.2 for ; Wed, 12 Feb 2025 22:20:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739427649; x=1740032449; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CPPPQaWJNVckUPtigjDkhfhBpenPmQjuRXN55oSVE/w=; b=U1STUNWGSDfSQS4AzTMOaPOpdfbbeaqvIWxxZ5tD1pm6SuKdcQPSC22PmrbhCgYCgq pRXVzXHXiLuFd8mrgc1SRFxoTVkG8KEMvup36gzEXtoEIE/5wBjTv9lgGX6bvcS5jGbS wW0LeQVUzZj3W4rgYxrUh8ERI3zRB+ETe47DTGSSo/+WZMAeEv9LvVddbQpTlEFKpvoz 51V3BjY1KC1XDWsKLDJjHzAySHoSsK65tYueyP3dwSjFKSWMdLb/bwajide5IVZchWeG AvEC4C5FywC2mYUsObcinZiEYYVFp32jUE1msDWfHIM4lRaE2la3kA5CFwQCKC2gct++ R+3Q== X-Forwarded-Encrypted: i=1; AJvYcCWxzgydHtqYueWfAkw1XF9DTWsyAWIn0vzWMUQXozjg13vcOKzN0MSj//diqaT0PoNNaT431ZTz@vger.kernel.org X-Gm-Message-State: AOJu0YxA6BmxEzvR/fooPHeOdtHRvfR/xjH7IAfTXUkXpHGfcYb44VaK XGV/TcEPvBwSr19YH8Z0zZ5dMfoMAsevO6klaNIfxg6UWsaSfgjgER0zRp0eNnRAVotzhbXOe90 Dh2jpyVX1T25JYYYQjqkAPdHAoQ8IYnP5h27m0DLXE8cDmavoGNf35YY= X-Gm-Gg: ASbGnct58C3HU5N/fLq3ZgoP6rrl1RbKG3VZfoa/9RzuLMs4Z7EbMRmPC1MH41J5T81 dndu7bS0AEGXgSQE6/mtq6Px26O2GOeV0qT4LcCokXv+2x9sD41qxH4ads7YsI8CI6RlvlKq+iy Tfl4/Nggy6JjWMTBQj4x5t9800pzT+vwpFKHe/eBLwH9ija69AMsL8y2wTBmF35gWKZSkhGmMSW af4yMJl32ORFlEG9xDXQzziAg9ofw1naq5lVnyz0b83M1Mn3K0CnzmfG+05uiGzwzCHvj/PAAHD fobxMq7aQr9/dj7xhahqWbrVjiFMXWbvCQ== X-Received: by 2002:a05:600c:34cf:b0:431:3bf9:3ebb with SMTP id 5b1f17b1804b1-439581b2618mr55155285e9.24.1739427649056; Wed, 12 Feb 2025 22:20:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IER6/42+eVDeZwjdE+jxN4B0+qhxJwM/n+zSdf4mIKkK9A70FFseUlVSNAfLLV/nC108HkX3g== X-Received: by 2002:a05:600c:34cf:b0:431:3bf9:3ebb with SMTP id 5b1f17b1804b1-439581b2618mr55154855e9.24.1739427648614; Wed, 12 Feb 2025 22:20:48 -0800 (PST) Received: from jlelli-thinkpadt14gen4.remote.csb ([151.29.34.42]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4395a1aa779sm38582615e9.30.2025.02.12.22.20.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Feb 2025 22:20:48 -0800 (PST) Date: Thu, 13 Feb 2025 07:20:45 +0100 From: Juri Lelli To: Dietmar Eggemann Cc: Christian Loehle , Jon Hunter , Thierry Reding , Waiman Long , Tejun Heo , Johannes Weiner , Michal Koutny , Ingo Molnar , Peter Zijlstra , Vincent Guittot , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Phil Auld , Qais Yousef , Sebastian Andrzej Siewior , "Joel Fernandes (Google)" , Suleiman Souhlal , Aashish Sharma , Shin Kawamura , Vineeth Remanan Pillai , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, "linux-tegra@vger.kernel.org" Subject: Re: [PATCH v2 3/2] sched/deadline: Check bandwidth overflow earlier for hotplug Message-ID: References: <8572b3bc-46ec-4180-ba55-aa6b9ab7502b@nvidia.com> <5a36a2e8-bd78-4875-9b9e-814468ca6692@arm.com> <8ff19556-a656-4f11-a10c-6f9b92ec9cea@arm.com> <285a43db-c36d-400e-8041-0566f089a482@arm.com> Precedence: bulk X-Mailing-List: cgroups@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <285a43db-c36d-400e-8041-0566f089a482@arm.com> On 12/02/25 19:22, Dietmar Eggemann wrote: > On 11/02/2025 11:42, Juri Lelli wrote: ... > > What about we actually ignore them consistently? We already do that for > > admission control, so maybe we can do that when rebuilding domains as > > well (until we find maybe a better way to deal with them). > > > > Does the following make any difference? > > It at least seems to solve the issue. And like you mentioned on irc, we > don't know the bw req of sugov anyway. > > So with this change we start with 'dl_bw->total_bw = 0' even w/ sugov tasks. > > dl_rq[0]: > .dl_nr_running : 0 > .dl_bw->bw : 996147 > .dl_bw->total_bw : 0 <-- ! > > IMHO, people who want to run serious DL can always check whether there > are already these infrastructural DL tasks or even avoid schedutil. It definitely not ideal and admittedly gross, but not worse than what we are doing already considering we ignore sugovs at AC and the current bandwidth allocation its there only to help with PI. So, duck tape. :/ A more proper way to work with this would entail coming up with sensible bandwidth allocation for sugovs, but that's most probably hardware specific, so I am not sure how we can make that general enough. Anyway, looks like Jon was still seeing the issue. I asked him to verify he is using all the proposed changes. Let's see what he reports. Best, Juri