From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35D77227BB7 for ; Wed, 5 Feb 2025 06:54:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738738442; cv=none; b=oLfXuRdh6nHRamQ4kFVxRf8XslK+60nmjsZ+GsiJj8FtnJo41gmot33prqUnGj4ugj3EDhwD59ZuTo0uL4kuJOiH91BVvd9bIYn6zdulTkjl3Ge+e1qKVL23Y8fBYRkA6WdwvIVPVkIpZiM3X3+QgHsrRLOKvGkD286zL2Q9+IQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738738442; c=relaxed/simple; bh=cWbO8HKmw8z2ZMTH0xbgQo1v4JbWKY6SdNB1Q44Twjg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=M+Ftij29eshHkcwiUUoy2f2Ib7f2H9k1IL1PCcgsEqsKw4zo/AKNb1R65TVcmi1/AdbA7RMeGSNVYgQ4sTfOfAIA/mF5f2PmG9DV1BqpcB5Itka+li6wO9cnSom0QddpYjm4wb2fyGoC1mobDhG1u+gHUNZsPnLHA4reVxA9GnQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=DSGlf0Gl; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="DSGlf0Gl" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738738440; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ig+/O8/8C9meWS9i5E5x4FYET8uunPEIglzfgflUkxo=; b=DSGlf0GlVxFMbmLEd+jVjBQMplLBeGkmjhRpeg9QccaQp1U5srGIsM9lg3n77FK80cPXS4 2bT3rbzwAakhljugGKU/o9TDrgYNV0v9qRS3OGjA5qqevwkF2VB9cGCpGAtBvKte56TiNs nWUrnMgpoiLLqxUSmIAdPpE4fWWPyL0= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-218-Iqdhz2cMOXKcpi9pshXXUw-1; Wed, 05 Feb 2025 01:53:58 -0500 X-MC-Unique: Iqdhz2cMOXKcpi9pshXXUw-1 X-Mimecast-MFC-AGG-ID: Iqdhz2cMOXKcpi9pshXXUw Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4388eee7073so2021465e9.0 for ; Tue, 04 Feb 2025 22:53:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738738437; x=1739343237; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Ig+/O8/8C9meWS9i5E5x4FYET8uunPEIglzfgflUkxo=; b=u15Ipbz4mdYdoAgOLB+INYZnAIe1/DSOfcHAy3vlWQT7bdsIORayzCprM/RSfYkFF1 mrW1EI5O3s4ANCxCasD/LODt8tfarXVTpzyiohpRweIDOo+EkqFnIruXMEj3DdK2Ryh2 ZS05eA2CJp/G2SEz5uj5cdt30nIj+b6RUny3Ny25LsqPR+xdIhuMlqCQGo+f3bkD2dGl QAw+S7jBrYiETNml82eucO2uUY6DBjY1lZ980W14AJ42UAd3srMpTQX2sctsGCuVmZpg G2kfklFF6n3houMsnJFBG3uFqTYQg5egqOjb4sK09PaAcsNV7+W+hoP0pcpeqtSwkA8f r2nA== X-Forwarded-Encrypted: i=1; AJvYcCXOJ3njJEunWTJkYYLX6eifMQFNWCFazEoXY8j6XqYMTY6BEmkwgzu26vox8o/+i7vwBDyfAcDI@vger.kernel.org X-Gm-Message-State: AOJu0YxzWp5oKPCI8LcNIV01WqN6ZzDFfecmeRQbGqJF1WQ6O06tlJlf qR9cTPj0VmtTgyThyaRb4ILVGzCtNZ2CQuaA6b+Q4GNz/Lxgd6scIk99U/sMLy5HWfVvGmErdAT CTiWA41ebWyBnGPlTmfrnEJ/qSxp3IDW4dHuT3hAcA45Ki2/0P3gKIk4= X-Gm-Gg: ASbGnct8bkANzwT5DDxHx5HFgjtJsKgn+SYkLGmTnOErLAcosCT8cv/IBrR1QB3swUn 8G52vE7G4TEwUoowvtuSry2zMbQRuv4MugP1NWNX1WREZ7uKzeYePoMfLuU5JBIg4PvlFNzM4kZ BWmk0qAaVIRbrjxCVA3BRjRGrChG+Q7H4eScgvL0Dk/ijv9A4DaYIPol4ekdvhv31LLpk21HQnx kP8ASomTQQQ3JzmKnrPh0AZoz35wSiR5W3PdfYTDGl9rn10ZkVCjoW5ddEiVtKKwj1KBwSoct2Q YPYcfMbD2NcZPHCfyDgRAK2dODvcGRXFUbsf X-Received: by 2002:a05:6000:184c:b0:38d:b7dc:30b8 with SMTP id ffacd0b85a97d-38db7dc3509mr21329f8f.18.1738738436798; Tue, 04 Feb 2025 22:53:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IFGpckBtgHNmxTU7R59xIWWBoy3feR6+6IjsVYrKHmwkhizPVL0uHMyp9QXQa1ReNMzYO5Zcg== X-Received: by 2002:a05:6000:184c:b0:38d:b7dc:30b8 with SMTP id ffacd0b85a97d-38db7dc3509mr21291f8f.18.1738738436348; Tue, 04 Feb 2025 22:53:56 -0800 (PST) Received: from jlelli-thinkpadt14gen4.remote.csb ([151.29.128.176]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4390d96536asm11146655e9.18.2025.02.04.22.53.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Feb 2025 22:53:55 -0800 (PST) Date: Wed, 5 Feb 2025 07:53:53 +0100 From: Juri Lelli To: Jon Hunter Cc: Thierry Reding , Waiman Long , Tejun Heo , Johannes Weiner , Michal Koutny , Ingo Molnar , Peter Zijlstra , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Phil Auld , Qais Yousef , Sebastian Andrzej Siewior , "Joel Fernandes (Google)" , Suleiman Souhlal , Aashish Sharma , Shin Kawamura , Vineeth Remanan Pillai , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, "linux-tegra@vger.kernel.org" Subject: Re: [PATCH v2 3/2] sched/deadline: Check bandwidth overflow earlier for hotplug Message-ID: References: <5d7e5c02-00ee-4891-a8cf-09abe3e089e1@nvidia.com> Precedence: bulk X-Mailing-List: cgroups@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On 03/02/25 11:01, Jon Hunter wrote: > Hi Juri, > > On 16/01/2025 15:55, Juri Lelli wrote: > > On 16/01/25 13:14, Jon Hunter wrote: ... > > > [ 210.595431] dl_bw_manage: cpu=5 cap=3072 fair_server_bw=52428 total_bw=209712 dl_bw_cpus=4 > > > [ 210.606269] dl_bw_manage: cpu=4 cap=2048 fair_server_bw=52428 total_bw=157284 dl_bw_cpus=3 > > > [ 210.617281] dl_bw_manage: cpu=3 cap=1024 fair_server_bw=52428 total_bw=104856 dl_bw_cpus=2 > > > [ 210.627205] dl_bw_manage: cpu=2 cap=1024 fair_server_bw=52428 total_bw=262140 dl_bw_cpus=2 > > > [ 210.637752] dl_bw_manage: cpu=1 cap=0 fair_server_bw=52428 total_bw=262140 dl_bw_cpus=1 > > ^ > > Different than before but still not what I expected. Looks like there > > are conditions/path I currently cannot replicate on my setup, so more > > thinking. Unfortunately I will be out traveling next week, so this > > might required a bit of time. > > > I see that this is now in the mainline and our board is still failing to > suspend. Let me know if there is anything else you need me to test. Ah, can you actually add 'sched_verbose' and to your kernel cmdline? It should print our additional debug info on the console when domains get reconfigured by hotplug/suspends, e.g. dl_bw_manage: cpu=3 cap=3072 fair_server_bw=52428 total_bw=209712 dl_bw_cpus=4 CPU0 attaching NULL sched-domain. CPU3 attaching NULL sched-domain. CPU4 attaching NULL sched-domain. CPU5 attaching NULL sched-domain. CPU0 attaching sched-domain(s): domain-0: span=0,4-5 level=MC groups: 0:{ span=0 cap=766 }, 4:{ span=4 cap=908 }, 5:{ span=5 cap=989 } CPU4 attaching sched-domain(s): domain-0: span=0,4-5 level=MC groups: 4:{ span=4 cap=908 }, 5:{ span=5 cap=989 }, 0:{ span=0 cap=766 } CPU5 attaching sched-domain(s): domain-0: span=0,4-5 level=MC groups: 5:{ span=5 cap=989 }, 0:{ span=0 cap=766 }, 4:{ span=4 cap=908 } root domain span: 0,4-5 rd 0,4-5: Checking EAS, CPUs do not have asymmetric capacities psci: CPU3 killed (polled 0 ms) Can you please share this information as well if you are able to collect it (while still running with my last proposed fix)? Thanks! Juri