From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 176C5256C6B for ; Mon, 10 Feb 2025 17:09:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739207355; cv=none; b=HifGuL8RlMWZDE5w5FhLaweSyz9Ry2goh5BIhSC1Ne0/uAOTWCgJieqOFjqZOyxJP+2muyIIsYBrjsQd3/adxpl4CgoPZwQLzFb1N2/nHJ+OHnSdvvfdNSiia2iYixLDEAyCjLjZZSVART6NOokMvyzMLwFZoAmGayEFn3k30bc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739207355; c=relaxed/simple; bh=HOuWt82jq7ygkKCFtxmgpdL6DwPRgmClVPVz8aUf/uA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Yy08d6OsXSVfVmP2UXBMjeHzNx85cbgEi3ZVnfyn73ywZtV1cAFwAC6oJjOdhB/LXBQqMjrqYrTywBV55uj/uBys9HPwT5zAb9UUamgjHRDGphrybvi+Jnj8Lk1bZ63X2Y7POf2WFZvQIxMWSobkGEthUC2keVMOACrdZZHkZ64= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Co8zl6uw; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Co8zl6uw" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739207353; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=75DhKP5p4pHL8SboeTssQDPO6tHFPAizpkaf2emg0Pc=; b=Co8zl6uw8gvDe9UnnP0greTPfHYznU7ExJUhrgg9H90Lky/Jsq0ChgFPPla8WdQokqTfT0 e8tVo1Whamti5kNPCb8yf3kQ/h37q9TStWbZ3DF4HW5w02d/Np/8CabvauMiFzWvHwjMHh kiDBDBTb8kgPov/CQAkpXIK4DKnKL8k= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-61-3gJ_lo9GNMmHX0py15rdXA-1; Mon, 10 Feb 2025 12:09:11 -0500 X-MC-Unique: 3gJ_lo9GNMmHX0py15rdXA-1 X-Mimecast-MFC-AGG-ID: 3gJ_lo9GNMmHX0py15rdXA Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4394c489babso1883475e9.1 for ; Mon, 10 Feb 2025 09:09:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739207350; x=1739812150; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=75DhKP5p4pHL8SboeTssQDPO6tHFPAizpkaf2emg0Pc=; b=mKdT5wE3onqpb6ei9lgbJ/6RtufSiObGS9KUzp16QD7N7qFXJEZ74G7fW7LnWGovaY CmoXrf5m5OZqnSv/AxnP9ZG7gjAxk/L7hLPJEWirDX8zGnCWBnkWsDjB7KWZUCWLcWIo 2yuMXTApiUV/MdZSjlm2RWOSvBcKPFANPX+WZ26hXY+AiPFrFeG+QPCBmrwQCTpVvmtc 2FJn15Pzd+WpQvRziPgul2j0dwTIwHDZMiUcblh1fTnTTmqSnZ3uHSt3yJ1UQ4DJ1j6q nJ1nMl4C8jCkLJB1ZCJec4RHaBquv7W8y+N33XEJ/hAyFiw8uSnreZcH4Enc+puikNRb rDXQ== X-Forwarded-Encrypted: i=1; AJvYcCXS7vWk+XSfxGGyqqNITBgKEBtB1xF++i2LuNvQ/3rVUyOscXRwyqshPB698lx/G/m+8Nim6kA0@vger.kernel.org X-Gm-Message-State: AOJu0YyTYR+KtbFWwQukP6uCx3r/b0Ow2WU+c25brmnSt1TKWTbxTzEf m2dcixlNXgga8IbW2dyxxKrao6l2v+rDIniCWplx+rZ2B6OVgbWnvA65g2omtibwQOesWeDSMSP DDvhUlnT7pjC9nO4T7mWzI0yVvkMBHuPqzg+yuNrXoQ7sWpyL7/Sr24I= X-Gm-Gg: ASbGncuQH65auSAAPR4XCVtdDQJa9gMeXNzklA4ELHu+5ak0HcVpliIp3y27x8W00/t VI/KbNw2P3mFUECJcuLV5T+dKfVGG558dJlkiFeX6XVkyjVfDkyJv3/btdmUgmfs0ckWCxIzCaf WHm95RnI6IWNkNLBs+ZDg1JkvuL42I7e30g6ufLg/u65hX4xCJ5LCSFmo5XwwMi6+AFeyuWn0EX /C7gIK2AR/J9XdcOvgLxdd3zzAHiwkKu+S4OjWo4dZRMK/mczm2/JQauQ7NEY8St67VNlRq6jlv GB1thzeMK9t9FFtV7Z/qHazTf72sBRDRfQ== X-Received: by 2002:a05:6000:1847:b0:38d:d18e:8811 with SMTP id ffacd0b85a97d-38dd18e88ccmr8244800f8f.25.1739207349736; Mon, 10 Feb 2025 09:09:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IF4iWM6+kcMn/xG5VIs8/39JBzO5XwyaWmPrE9jrgtQyQ7EiaBt4luvYYTOSu7zPwW07wtZug== X-Received: by 2002:a05:6000:1847:b0:38d:d18e:8811 with SMTP id ffacd0b85a97d-38dd18e88ccmr8244771f8f.25.1739207349294; Mon, 10 Feb 2025 09:09:09 -0800 (PST) Received: from jlelli-thinkpadt14gen4.remote.csb ([151.29.34.42]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4390d964c7csm185123115e9.17.2025.02.10.09.09.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 09:09:08 -0800 (PST) Date: Mon, 10 Feb 2025 18:09:05 +0100 From: Juri Lelli To: Christian Loehle Cc: Jon Hunter , Dietmar Eggemann , Thierry Reding , Waiman Long , Tejun Heo , Johannes Weiner , Michal Koutny , Ingo Molnar , Peter Zijlstra , Vincent Guittot , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Phil Auld , Qais Yousef , Sebastian Andrzej Siewior , "Joel Fernandes (Google)" , Suleiman Souhlal , Aashish Sharma , Shin Kawamura , Vineeth Remanan Pillai , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, "linux-tegra@vger.kernel.org" Subject: Re: [PATCH v2 3/2] sched/deadline: Check bandwidth overflow earlier for hotplug Message-ID: References: <8572b3bc-46ec-4180-ba55-aa6b9ab7502b@nvidia.com> <5a36a2e8-bd78-4875-9b9e-814468ca6692@arm.com> <8ff19556-a656-4f11-a10c-6f9b92ec9cea@arm.com> Precedence: bulk X-Mailing-List: cgroups@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8ff19556-a656-4f11-a10c-6f9b92ec9cea@arm.com> Hi Christian, Thanks for taking a look as well. On 07/02/25 15:55, Christian Loehle wrote: > On 2/7/25 14:04, Jon Hunter wrote: > > > > > > On 07/02/2025 13:38, Dietmar Eggemann wrote: > >> On 07/02/2025 11:38, Jon Hunter wrote: > >>> > >>> On 06/02/2025 09:29, Juri Lelli wrote: > >>>> On 05/02/25 16:56, Jon Hunter wrote: > >>>> > >>>> ... > >>>> > >>>>> Thanks! That did make it easier :-) > >>>>> > >>>>> Here is what I see ... > >>>> > >>>> Thanks! > >>>> > >>>> Still different from what I can repro over here, so, unfortunately, I > >>>> had to add additional debug printks. Pushed to the same branch/repo. > >>>> > >>>> Could I ask for another run with it? Please also share the complete > >>>> dmesg from boot, as I would need to check debug output when CPUs are > >>>> first onlined. > >> > >> So you have a system with 2 big and 4 LITTLE CPUs (Denver0 Denver1 A57_0 > >> A57_1 A57_2 A57_3) in one MC sched domain and (Denver1 and A57_0) are > >> isol CPUs? > > > > I believe that 1-2 are the denvers (even thought they are listed as 0-1 in device-tree). > > Interesting, I have yet to reproduce this with equal capacities in isolcpus. > Maybe I didn't try hard enough yet. > > > > >> This should be easy to set up for me on my Juno-r0 [A53 A57 A57 A53 A53 A53] > > > > Yes I think it is similar to this. > > > > Thanks! > > Jon > > > > I could reproduce that on a different LLLLbb with isolcpus=3,4 (Lb) and > the offlining order: > echo 0 > /sys/devices/system/cpu/cpu5/online > echo 0 > /sys/devices/system/cpu/cpu1/online > echo 0 > /sys/devices/system/cpu/cpu3/online > echo 0 > /sys/devices/system/cpu/cpu2/online > echo 0 > /sys/devices/system/cpu/cpu4/online > > while the following offlining order succeeds: > echo 0 > /sys/devices/system/cpu/cpu5/online > echo 0 > /sys/devices/system/cpu/cpu4/online > echo 0 > /sys/devices/system/cpu/cpu1/online > echo 0 > /sys/devices/system/cpu/cpu2/online > echo 0 > /sys/devices/system/cpu/cpu3/online > (Both offline an isolcpus last, both have CPU0 online) > > The issue only triggers with sugov DL threads (I guess that's obvious, but > just to mention it). It wasn't obvious to me at first :). So thanks for confirming. > I'll investigate some more later but wanted to share for now. So, problem actually is that I am not yet sure what we should do with sugovs' bandwidth wrt root domain accounting. W/o isolation it's all good, as it gets accounted for correctly on the dynamic domains sugov tasks can run on. But with isolation and sugov affected_cpus that cross isolation domains (e.g., one BIG one little), we can get into troubles not knowing if sugov contribution should fall on the DEF or DYN domain. Hummm, need to think more about it. Thanks, Juri