public inbox for cgroups@vger.kernel.org
 help / color / mirror / Atom feed
From: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
To: Michal Hocko <mhocko-IBi9RG/b67k@public.gmane.org>
Cc: Suren Baghdasaryan
	<surenb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
	tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org,
	peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
	johunt-JqFfY2XvxFXQT0dZR+AlfA@public.gmane.org,
	keescook-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
	quic_sudaraja-jfJNa2p1gH1BDgjK7y7TUQ@public.gmane.org,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/1] psi: remove 500ms min window size limitation for triggers
Date: Thu, 2 Mar 2023 12:58:57 -0500	[thread overview]
Message-ID: <ZADj4YX4uftK/Frh@cmpxchg.org> (raw)
In-Reply-To: <ZADf27Kx5mbFev+I-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>

On Thu, Mar 02, 2023 at 06:41:47PM +0100, Michal Hocko wrote:
> On Thu 02-03-23 08:13:54, Suren Baghdasaryan wrote:
> [...]
> > Let's roll this check without additional changes and then consolidate
> > the checking inside psi_trigger_create() in a separate patch. If
> > anybody objects to the late permission check we will just revert that
> > last change without affecting anything else.
> 
> Permissions checks at write time are problematic because userspace
> cannot drop privileges. Also I think it would be an antipattern for how
> we do this in general. 

The permissions can be checked against opener privileges through
file->f_cred. This allows dropping privileges, as well as passing the
fd to a trusted but unprivileged process to delegate trigger setup.

I agree with keeping it in open() for now. But it will matter when we
distinguish between privileged and unprivileged trigger parameters.

  parent reply	other threads:[~2023-03-02 17:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-01 19:34 [PATCH 1/1] psi: remove 500ms min window size limitation for triggers Suren Baghdasaryan
     [not found] ` <20230301193403.1507484-1-surenb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2023-03-01 20:07   ` Johannes Weiner
     [not found]     ` <Y/+wlg5L8A1iebya-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2023-03-01 20:48       ` Suren Baghdasaryan
     [not found]         ` <CAJuCfpHhA4XpoE96u5CPktDcSChUkQG_Ax58NzJOiOoF2K+3qQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2023-03-01 21:00           ` Kalesh Singh
2023-03-02 15:30           ` Johannes Weiner
     [not found]             ` <ZADBCEk68W1aGJAV-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2023-03-02 16:13               ` Suren Baghdasaryan
     [not found]                 ` <CAJuCfpHF=9Dv_Yzph5jNmR1ZfTf7Lf=_oShztyLUq0ps_D=osQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2023-03-02 17:41                   ` Michal Hocko
     [not found]                     ` <ZADf27Kx5mbFev+I-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2023-03-02 17:58                       ` Johannes Weiner [this message]
2023-03-02 13:58 ` Michal Hocko
     [not found]   ` <ZACrgV4f39P/2sZO-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2023-03-02 16:08     ` Suren Baghdasaryan
     [not found]       ` <CAJuCfpH+yuynm+8LDbcOyh-q_PFTOz-FygxO9aSg8=RUR3LT+Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2023-03-02 17:39         ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZADj4YX4uftK/Frh@cmpxchg.org \
    --to=hannes-druugvl0lcnafugrpc6u6w@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=johunt-JqFfY2XvxFXQT0dZR+AlfA@public.gmane.org \
    --cc=keescook-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
    --cc=lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org \
    --cc=mhocko-IBi9RG/b67k@public.gmane.org \
    --cc=peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
    --cc=quic_sudaraja-jfJNa2p1gH1BDgjK7y7TUQ@public.gmane.org \
    --cc=surenb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    --cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox