From: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
To: Yosry Ahmed <yosryahmed-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Cc: "Tejun Heo" <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Josef Bacik" <josef-DigfWCa+lFGyeJad7bwFQA@public.gmane.org>,
"Jens Axboe" <axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>,
"Zefan Li" <lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org>,
"Michal Hocko" <mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Roman Gushchin"
<roman.gushchin-fxUVXftIFDnyG1zEObXtfA@public.gmane.org>,
"Shakeel Butt" <shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
"Muchun Song"
<muchun.song-fxUVXftIFDnyG1zEObXtfA@public.gmane.org>,
"Andrew Morton"
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
"Michal Koutný" <mkoutny-IBi9RG/b67k@public.gmane.org>,
"Vasily Averin"
<vasily.averin-fxUVXftIFDnyG1zEObXtfA@public.gmane.org>,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
bpf-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v1 1/9] cgroup: rename cgroup_rstat_flush_"irqsafe" to "atomic"
Date: Tue, 28 Mar 2023 13:42:33 -0400 [thread overview]
Message-ID: <ZCMnCVe4UZx5E8KM@cmpxchg.org> (raw)
In-Reply-To: <20230328061638.203420-2-yosryahmed-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
On Tue, Mar 28, 2023 at 06:16:30AM +0000, Yosry Ahmed wrote:
> cgroup_rstat_flush_irqsafe() can be a confusing name. It may read as
> "irqs are disabled throughout", which is what the current implementation
> does (currently under discussion [1]), but is not the intention. The
> intention is that this function is safe to call from atomic contexts.
> Name it as such.
>
> Suggested-by: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
> Signed-off-by: Yosry Ahmed <yosryahmed-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Acked-by: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
next prev parent reply other threads:[~2023-03-28 17:42 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-28 6:16 [PATCH v1 0/9] memcg: make rstat flushing irq and sleep friendly Yosry Ahmed
2023-03-28 6:16 ` [PATCH v1 2/9] memcg: rename mem_cgroup_flush_stats_"delayed" to "ratelimited" Yosry Ahmed
2023-03-28 13:25 ` Shakeel Butt
[not found] ` <20230328061638.203420-3-yosryahmed-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2023-03-28 17:42 ` Johannes Weiner
2023-03-28 6:16 ` [PATCH v1 3/9] memcg: do not flush stats in irq context Yosry Ahmed
2023-03-28 13:26 ` Shakeel Butt
2023-03-28 17:43 ` Johannes Weiner
2023-03-28 6:16 ` [PATCH v1 4/9] cgroup: rstat: add WARN_ON_ONCE() if flushing outside task context Yosry Ahmed
2023-03-28 14:59 ` Shakeel Butt
2023-03-28 17:49 ` Johannes Weiner
2023-03-28 18:59 ` Yosry Ahmed
[not found] ` <CAJD7tkYA=0rKSmtQzYQpZ2DuUoJq0bQcVqPgSpVEs0M4zAktnw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2023-03-28 22:18 ` Yosry Ahmed
2023-03-28 6:16 ` [PATCH v1 5/9] memcg: replace stats_flush_lock with an atomic Yosry Ahmed
[not found] ` <20230328061638.203420-6-yosryahmed-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2023-03-28 14:15 ` Shakeel Butt
[not found] ` <20230328141523.txyhl7wt7wtvssea-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2023-03-28 18:52 ` Yosry Ahmed
2023-03-28 19:28 ` Shakeel Butt
[not found] ` <CALvZod4Gsngc6MjXdk4s5+ePVjsgcVppdRmsQovN6gSrxzdbfA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2023-03-28 19:34 ` Yosry Ahmed
2023-03-28 19:42 ` Yosry Ahmed
2023-03-28 17:53 ` Johannes Weiner
2023-03-28 6:16 ` [PATCH v1 6/9] memcg: sleep during flushing stats in safe contexts Yosry Ahmed
2023-03-28 15:09 ` Shakeel Butt
2023-03-28 18:35 ` Johannes Weiner
[not found] ` <ZCMzfQuo9IhWVzRA-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2023-03-28 18:45 ` Yosry Ahmed
2023-03-28 19:06 ` Johannes Weiner
[not found] ` <ZCM6m/4ujEqvFVsn-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2023-03-28 19:26 ` Yosry Ahmed
2023-03-28 6:16 ` [PATCH v1 7/9] workingset: memcg: sleep when flushing stats in workingset_refault() Yosry Ahmed
2023-03-28 15:18 ` Shakeel Butt
[not found] ` <CALvZod5_NVTrYUhLjc3Me=CC6y3R4bhA71mCt-jXo0rX+2zUxw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2023-03-28 18:47 ` Johannes Weiner
2023-03-28 19:25 ` Yosry Ahmed
[not found] ` <20230328061638.203420-8-yosryahmed-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2023-03-28 18:43 ` Johannes Weiner
[not found] ` <20230328061638.203420-1-yosryahmed-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2023-03-28 6:16 ` [PATCH v1 1/9] cgroup: rename cgroup_rstat_flush_"irqsafe" to "atomic" Yosry Ahmed
2023-03-28 13:24 ` Shakeel Butt
[not found] ` <20230328061638.203420-2-yosryahmed-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2023-03-28 17:42 ` Johannes Weiner [this message]
2023-03-28 6:16 ` [PATCH v1 8/9] vmscan: memcg: sleep when flushing stats during reclaim Yosry Ahmed
2023-03-28 15:19 ` Shakeel Butt
[not found] ` <CALvZod7wJ-e-dHEhMynquiqQWFU2j+05wUyUe_yv_rBqJLu2rw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2023-03-28 19:01 ` Yosry Ahmed
[not found] ` <CAJD7tkaKh4w3roqau4V93Q022BG280yzdsh1YSVenZCLm0qVow-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2023-03-28 19:29 ` Shakeel Butt
2023-03-28 18:49 ` Johannes Weiner
2023-03-28 6:16 ` [PATCH v1 9/9] memcg: do not modify rstat tree for zero updates Yosry Ahmed
2023-03-28 15:20 ` Shakeel Butt
2023-03-28 18:50 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCMnCVe4UZx5E8KM@cmpxchg.org \
--to=hannes-druugvl0lcnafugrpc6u6w@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org \
--cc=bpf-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=josef-DigfWCa+lFGyeJad7bwFQA@public.gmane.org \
--cc=linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org \
--cc=mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=mkoutny-IBi9RG/b67k@public.gmane.org \
--cc=muchun.song-fxUVXftIFDnyG1zEObXtfA@public.gmane.org \
--cc=roman.gushchin-fxUVXftIFDnyG1zEObXtfA@public.gmane.org \
--cc=shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=vasily.averin-fxUVXftIFDnyG1zEObXtfA@public.gmane.org \
--cc=yosryahmed-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox