From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH 00/40] Memory allocation profiling Date: Wed, 3 May 2023 08:58:51 -1000 Message-ID: References: <20230501165450.15352-1-surenb@google.com> <20230503180726.GA196054@cmpxchg.org> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683140334; x=1685732334; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=vMlAqtjRc2HuzX77sJKufpwTYm/Gq3h8+fD7OUvgqfE=; b=AAvxk54YlMnkI7FdWDgkmXppZ5N5YVAtZzB/uFzgetK350E1VsosLNsIn+t9yAmlyz Mpf/EdDThAl6AdsQ4NqZZ4WQmsihQ4PIOjP2ktSZnRqbu/hpU+fSBV+6Seq32dABAuoB fgBMvXiDGIWraIMuHQyLJ8k8C2Rfu3BrjRS/alNIzOPn/3Xdw2WUHmjkDBEutrfMrPpb QTijZH34gDsEJTP9EXOMMbAzxdlErf6OrxB7h8VV2kzs6tN2Aq3j/W560a3R8Pg4/lCz FYHP8xcU1EYp/9E+JwiaUk9zf6GvPs+LS2bU4OlgAsosubDIcUNZjh57x1aZiOnb8NOJ sALg== Sender: Tejun Heo Content-Disposition: inline In-Reply-To: List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Kent Overstreet Cc: Johannes Weiner , Michal Hocko , Suren Baghdasaryan , akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, vbabka-AlSwsSmVLrQ@public.gmane.org, roman.gushchin-fxUVXftIFDnyG1zEObXtfA@public.gmane.org, mgorman-l3A5Bk7waGM@public.gmane.org, dave-h16yJtLeMjHk1uMJSBkQmQ@public.gmane.org, willy-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, liam.howlett-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org, corbet-T1hC0tSOHrs@public.gmane.org, void-gq6j2QGBifHby3iVrkZq2A@public.gmane.org, peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, juri.lelli-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, ldufour-tEXmvtCZX7AybS5Ee8rs3A@public.gmane.org, catalin.marinas-5wv7dgnIgG8@public.gmane.org, will-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, arnd-r2nGTMty4D4@public.gmane.org, tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org, mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, dave.hansen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, peterx-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, david-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org, mcgrof-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, masahiroy-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, nathan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, dennis-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, muchun.song-fxUVXftIFDnyG1zEObXtfA@public.gmane.org, rppt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, paulmck-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, pasha.tatashin-2EmBfe737+LQT0dZR+AlfA@public.gmane.org, yosryahmed-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, yuzhao-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, dhowells@redhat.c On Wed, May 03, 2023 at 02:56:44PM -0400, Kent Overstreet wrote: > On Wed, May 03, 2023 at 08:40:07AM -1000, Tejun Heo wrote: > > > Yeah, easy / default visibility argument does make sense to me. > > > > So, a bit of addition here. If this is the thrust, the debugfs part seems > > rather redundant, right? That's trivially obtainable with tracing / bpf and > > in a more flexible and performant manner. Also, are we happy with recording > > just single depth for persistent tracking? > > Not sure what you're envisioning? > > I'd consider the debugfs interface pretty integral; it's much more > discoverable for users, and it's hardly any code out of the whole > patchset. You can do the same thing with a bpftrace one liner tho. That's rather difficult to beat. Thanks. -- tejun