From: Juri Lelli <juri.lelli-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Peter Zijlstra <peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Cc: Ingo Molnar <mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Qais Yousef <qyousef-wp2msK0BRk8tq7phqP6ubQ@public.gmane.org>,
Waiman Long <longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Zefan Li <lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org>,
Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
Hao Luo <haoluo-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
Dietmar Eggemann <dietmar.eggemann-5wv7dgnIgG8@public.gmane.org>,
Steven Rostedt <rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
luca.abeni-5rdYK369eBLQB0XuIGIEkQ@public.gmane.org,
claudio-YOzL5CV4y4YG1A2ADO40+w@public.gmane.org,
tommaso.cucinotta-5rdYK369eBLQB0XuIGIEkQ@public.gmane.org,
bristot-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
mathieu.poirier-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Vincent Guittot
<vincent.guittot-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Wei Wang <wvw-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
Rick Yiu <rickyiu-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
Quentin Perret <qperret-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
Heiko Carstens <hca-tEXmvtCZX7AybS5Ee8rs3A@public.gmane.org>,
Vasily Gorbik <gor-tEXmvtCZX7AybS5Ee8rs3A@public.gmane.org>,
Alexander Gordeev
<agordeev-tEXmvtCZX7AybS5Ee8rs3A@public.gmane.org>
Subject: Re: [PATCH v2 0/6] sched/deadline: cpuset: Rework DEADLINE bandwidth restoration
Date: Thu, 4 May 2023 10:17:41 +0200 [thread overview]
Message-ID: <ZFNqJf+BQ0GMdr+y@localhost.localdomain> (raw)
In-Reply-To: <20230504062525.GF1734100-Nxj+rRp3nVydTX5a5knrm8zTDFooKrT+cvkQGrU6aU0@public.gmane.org>
On 04/05/23 08:25, Peter Zijlstra wrote:
> On Wed, May 03, 2023 at 09:22:22AM +0200, Juri Lelli wrote:
>
> > Dietmar Eggemann (2):
> > sched/deadline: Create DL BW alloc, free & check overflow interface
> > cgroup/cpuset: Free DL BW in case can_attach() fails
> >
> > Juri Lelli (4):
> > cgroup/cpuset: Rename functions dealing with DEADLINE accounting
> > sched/cpuset: Bring back cpuset_mutex
> > sched/cpuset: Keep track of SCHED_DEADLINE task in cpusets
> > cgroup/cpuset: Iterate only if DEADLINE tasks are present
> >
> > include/linux/cpuset.h | 12 +-
> > include/linux/sched.h | 4 +-
> > kernel/cgroup/cgroup.c | 4 +
> > kernel/cgroup/cpuset.c | 242 ++++++++++++++++++++++++++--------------
> > kernel/sched/core.c | 41 +++----
> > kernel/sched/deadline.c | 67 ++++++++---
> > kernel/sched/sched.h | 2 +-
> > 7 files changed, 244 insertions(+), 128 deletions(-)
>
> Aside from a few niggles, these look fine to me. Who were you expecting
> to merge these, tj or me?
Thanks for reviewing!
Not entirely sure, it's kind of split, but maybe the cgroup changes are
predominant (cpuset_mutex is probably contributing the most). So, maybe
tj? Assuming this looks good to him as well of course. :)
Thanks!
next prev parent reply other threads:[~2023-05-04 8:17 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-03 7:22 [PATCH v2 0/6] sched/deadline: cpuset: Rework DEADLINE bandwidth restoration Juri Lelli
[not found] ` <20230503072228.115707-1-juri.lelli-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2023-05-03 7:22 ` [PATCH v2 1/6] cgroup/cpuset: Rename functions dealing with DEADLINE accounting Juri Lelli
[not found] ` <20230503072228.115707-2-juri.lelli-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2023-05-03 17:54 ` Waiman Long
2023-05-03 7:22 ` [PATCH v2 2/6] sched/cpuset: Bring back cpuset_mutex Juri Lelli
[not found] ` <20230503072228.115707-3-juri.lelli-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2023-05-03 17:55 ` Waiman Long
2023-05-04 6:21 ` Peter Zijlstra
[not found] ` <20230504062105.GD1734100-Nxj+rRp3nVydTX5a5knrm8zTDFooKrT+cvkQGrU6aU0@public.gmane.org>
2023-05-04 8:13 ` Juri Lelli
2023-05-04 6:18 ` Peter Zijlstra
[not found] ` <20230504061842.GC1734100-Nxj+rRp3nVydTX5a5knrm8zTDFooKrT+cvkQGrU6aU0@public.gmane.org>
2023-05-04 8:13 ` Juri Lelli
2023-05-03 7:22 ` [PATCH v2 3/6] sched/cpuset: Keep track of SCHED_DEADLINE task in cpusets Juri Lelli
[not found] ` <20230503072228.115707-4-juri.lelli-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2023-05-03 17:56 ` Waiman Long
2023-05-03 7:22 ` [PATCH v2 4/6] cgroup/cpuset: Iterate only if DEADLINE tasks are present Juri Lelli
2023-05-03 17:56 ` Waiman Long
2023-05-03 7:22 ` [PATCH v2 5/6] sched/deadline: Create DL BW alloc, free & check overflow interface Juri Lelli
[not found] ` <20230503072228.115707-6-juri.lelli-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2023-05-03 17:45 ` Waiman Long
2023-05-04 6:23 ` Peter Zijlstra
[not found] ` <20230504062359.GE1734100-Nxj+rRp3nVydTX5a5knrm8zTDFooKrT+cvkQGrU6aU0@public.gmane.org>
2023-05-04 8:15 ` Juri Lelli
2023-05-04 17:21 ` Dietmar Eggemann
2023-05-04 6:25 ` [PATCH v2 0/6] sched/deadline: cpuset: Rework DEADLINE bandwidth restoration Peter Zijlstra
[not found] ` <20230504062525.GF1734100-Nxj+rRp3nVydTX5a5knrm8zTDFooKrT+cvkQGrU6aU0@public.gmane.org>
2023-05-04 8:17 ` Juri Lelli [this message]
[not found] ` <ZFNqJf+BQ0GMdr+y-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2023-05-05 19:31 ` Tejun Heo
2023-05-08 8:02 ` Juri Lelli
2023-05-03 7:22 ` [PATCH v2 6/6] cgroup/cpuset: Free DL BW in case can_attach() fails Juri Lelli
2023-05-03 18:02 ` Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZFNqJf+BQ0GMdr+y@localhost.localdomain \
--to=juri.lelli-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=agordeev-tEXmvtCZX7AybS5Ee8rs3A@public.gmane.org \
--cc=bristot-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=claudio-YOzL5CV4y4YG1A2ADO40+w@public.gmane.org \
--cc=dietmar.eggemann-5wv7dgnIgG8@public.gmane.org \
--cc=gor-tEXmvtCZX7AybS5Ee8rs3A@public.gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
--cc=haoluo-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=hca-tEXmvtCZX7AybS5Ee8rs3A@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org \
--cc=longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=luca.abeni-5rdYK369eBLQB0XuIGIEkQ@public.gmane.org \
--cc=mathieu.poirier-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=qperret-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=qyousef-wp2msK0BRk8tq7phqP6ubQ@public.gmane.org \
--cc=rickyiu-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=tommaso.cucinotta-5rdYK369eBLQB0XuIGIEkQ@public.gmane.org \
--cc=vincent.guittot-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=wvw-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox