From: Tejun Heo <tj@kernel.org>
To: Christian Brauner <brauner@kernel.org>
Cc: "Michal Koutný" <mkoutny@suse.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
cgroups@vger.kernel.org,
"Alexander Viro" <viro@zeniv.linux.org.uk>,
"Zefan Li" <lizefan.x@bytedance.com>,
"Johannes Weiner" <hannes@cmpxchg.org>,
"Dave Chinner" <dchinner@redhat.com>,
"Rik van Riel" <riel@surriel.com>,
"Jiri Wiesner" <jwiesner@suse.de>
Subject: Re: [RFC PATCH 2/3] cgroup: Rely on namespace_sem in current_cgns_cgroup_from_root explicitly
Date: Tue, 23 May 2023 09:12:31 -1000 [thread overview]
Message-ID: <ZG0QH7gvKNFj0n34@slm.duckdns.org> (raw)
In-Reply-To: <20230523-radar-gleich-781fd4006057@brauner>
Hello,
On Tue, May 23, 2023 at 12:42:46PM +0200, Christian Brauner wrote:
...
> Nope, we're not putting namespace_sem in a header. The code it protects
> is massively sensitive and it interacts with mount_lock and other locks.
> This stays private to fs/namespace.c as far as I'm concerned.
Michal, would it make sense to add a separate locking in cgroup.c? It'll add
a bit more overhead but not massively so and we should be able to get
similar gain without entangling with namespace locking.
Thanks.
--
tejun
next prev parent reply other threads:[~2023-05-23 19:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-02 13:38 [RFC PATCH 0/3] Rework locking when rendering mountinfo cgroup paths Michal Koutný
[not found] ` <20230502133847.14570-1-mkoutny-IBi9RG/b67k@public.gmane.org>
2023-05-02 13:38 ` [RFC PATCH 1/3] cgroup: Drop unused function for cgroup_path Michal Koutný
2023-05-02 19:58 ` Waiman Long
2023-05-02 13:38 ` [RFC PATCH 2/3] cgroup: Rely on namespace_sem in current_cgns_cgroup_from_root explicitly Michal Koutný
2023-05-02 19:50 ` Waiman Long
[not found] ` <20230502133847.14570-3-mkoutny-IBi9RG/b67k@public.gmane.org>
2023-05-23 10:42 ` Christian Brauner
2023-05-23 19:12 ` Tejun Heo [this message]
2023-05-02 13:38 ` [RFC PATCH 3/3] cgroup: Do not take css_set_lock in cgroup_show_path Michal Koutný
[not found] ` <20230502133847.14570-4-mkoutny-IBi9RG/b67k@public.gmane.org>
2023-05-02 19:56 ` Waiman Long
2023-05-05 15:45 ` Tejun Heo
2023-05-05 17:32 ` Michal Koutný
2023-05-05 18:17 ` Tejun Heo
2023-05-09 10:34 ` Michal Koutný
2023-05-22 20:55 ` Tejun Heo
2023-05-23 12:09 ` [RFC PATCH 0/3] Rework locking when rendering mountinfo cgroup paths Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZG0QH7gvKNFj0n34@slm.duckdns.org \
--to=tj@kernel.org \
--cc=brauner@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=dchinner@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=jwiesner@suse.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=mkoutny@suse.com \
--cc=riel@surriel.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox