public inbox for cgroups@vger.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Carlos Bilbao <carlos.bilbao@amd.com>
Cc: josef@toxicpanda.com, axboe@kernel.dk, cgroups@vger.kernel.org,
	linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	amd <amd@localhost.localdomain>
Subject: Re: [PATCH] blk-iocost: fix seq_printf compile type mismatch error
Date: Thu, 20 Jul 2023 10:05:26 -1000	[thread overview]
Message-ID: <ZLmThnoXvEqlgf_q@slm.duckdns.org> (raw)
In-Reply-To: <7044d6b3-a5d1-572d-a755-74f8d4fd31c5@amd.com>

On Tue, Jul 18, 2023 at 10:37:23AM -0500, Carlos Bilbao wrote:
> On 7/17/23 13:49, Tejun Heo wrote:
> > On Mon, Jul 17, 2023 at 09:18:52AM -0500, Carlos Bilbao wrote:
> > > From: amd <amd@localhost.localdomain>
> > > 
> > > Fix two type mismatch errors encountered while compiling blk-iocost.c with
> > > GCC version 13.1.1 that involved constant operator WEIGHT_ONE. Cast the
> > > result of the division operation to (unsigned int) to match the expected
> > > format specifier %u in two seq_printf invocations.
> > 
> > Can you detail the warnings? Was that on 32bit compiles?
> 
> The concrete error was: "format ‘%u’ expects argument of type ‘unsigned
> int’, but argument 3 has type ‘long unsigned int’". If I run:
> 
> $ echo | cpp -dM | grep __LP64__
> #define __LP64__ 1
> 
> which makes me believe it is not 32 bits.

So, we broke up the enum definitions so that WEIGHT_ONE doesn't end up being
a ulong. Which kernel are you building? Can you plesae try the current
linus#master?

Thanks.

-- 
tejun

  reply	other threads:[~2023-07-20 20:05 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20230717141852.153965-1-carlos.bilbao@amd.com>
     [not found] ` <20230717141852.153965-1-carlos.bilbao-5C7GfCeVMHo@public.gmane.org>
2023-07-17 14:23   ` [PATCH] blk-iocost: fix seq_printf compile type mismatch error Carlos Bilbao
2023-07-17 18:49   ` Tejun Heo
     [not found]     ` <ZLWNHuTGk0fy8pjE-NiLfg/pYEd1N0TnZuCh8vA@public.gmane.org>
2023-07-18 15:37       ` Carlos Bilbao
2023-07-20 20:05         ` Tejun Heo [this message]
2023-07-19  8:57     ` David Laight
     [not found]       ` <2b4540aadc3c4449a192aeed6211f232-1XygrNkDbNvwg4NCKwmqgw@public.gmane.org>
2023-07-20 20:06         ` 'Tejun Heo'
2023-07-21  8:05           ` David Laight
     [not found]             ` <fd89f72848da4569a19ec8a1ac9ec94e-1XygrNkDbNvwg4NCKwmqgw@public.gmane.org>
2023-07-21 17:58               ` 'Tejun Heo'
2023-07-21 22:32 ` Carlos Bilbao
     [not found]   ` <93557f79-c12c-3c3f-2c25-9ba50a618daa-5C7GfCeVMHo@public.gmane.org>
2023-07-22  1:14     ` Tejun Heo
     [not found]       ` <ZLstYbAzqkqwIRzy-NiLfg/pYEd1N0TnZuCh8vA@public.gmane.org>
2023-07-31 15:04         ` Carlos Bilbao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZLmThnoXvEqlgf_q@slm.duckdns.org \
    --to=tj@kernel.org \
    --cc=amd@localhost.localdomain \
    --cc=axboe@kernel.dk \
    --cc=carlos.bilbao@amd.com \
    --cc=cgroups@vger.kernel.org \
    --cc=josef@toxicpanda.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox