From: Michal Hocko <mhocko-IBi9RG/b67k@public.gmane.org>
To: "Michal Koutný" <mkoutny-IBi9RG/b67k@public.gmane.org>
Cc: Yosry Ahmed <yosryahmed-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
Roman Gushchin
<roman.gushchin-fxUVXftIFDnyG1zEObXtfA@public.gmane.org>,
Shakeel Butt <shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
Muchun Song <muchun.song-fxUVXftIFDnyG1zEObXtfA@public.gmane.org>,
Ivan Babrou <ivan-lDpJ742SOEtZroRs9YW3xA@public.gmane.org>,
Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Waiman Long <longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v4 3/4] mm: memcg: let non-unified root stats flushes help unified flushes
Date: Mon, 4 Sep 2023 17:41:10 +0200 [thread overview]
Message-ID: <ZPX6luPGqypp68+L@dhcp22.suse.cz> (raw)
In-Reply-To: <6tne52ip62ucev7nmnim3m7fhcydnwcytyxynrlxxgaf4cbqea@r4hec425izap>
On Mon 04-09-23 17:29:14, Michal Koutny wrote:
> Hello.
>
> On Mon, Sep 04, 2023 at 04:50:15PM +0200, Michal Hocko <mhocko-IBi9RG/b67k@public.gmane.org> wrote:
> > I have hard time to follow why we really want/need this. Does this cause
> > any observable changes to the behavior?
>
> Behavior change depends on how much userspace triggers the root memcg
> flush, from nothing to effectively offloading flushing to userspace tasks.
> (Theory^^^)
>
> It keeps stats_flush_threshold up to date representing global error
> estimate so that error-tolerant readers may save their time and it keeps
> the reasoning about the stats_flush_threshold effect simple.
So it also creates an undocumented but userspace visible behavior.
Something that userspace might start depending on, right?
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2023-09-04 15:41 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-31 16:56 [PATCH v4 0/4] memcg: non-unified flushing for userspace stats Yosry Ahmed
2023-08-31 16:56 ` [PATCH v4 1/4] mm: memcg: properly name and document unified stats flushing Yosry Ahmed
[not found] ` <20230831165611.2610118-2-yosryahmed-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2023-09-04 14:44 ` Michal Hocko
[not found] ` <ZPXtVLNIXk8trj2k-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2023-09-05 15:55 ` Yosry Ahmed
2023-08-31 16:56 ` [PATCH v4 3/4] mm: memcg: let non-unified root stats flushes help unified flushes Yosry Ahmed
2023-09-04 14:50 ` Michal Hocko
[not found] ` <ZPXupwjewuLgksAI-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2023-09-04 15:29 ` Michal Koutný
2023-09-04 15:41 ` Michal Hocko [this message]
[not found] ` <ZPX6luPGqypp68+L-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2023-09-05 14:10 ` Michal Koutný
2023-09-05 15:54 ` Yosry Ahmed
[not found] ` <CAJD7tkaHVtMiMYFocNiABuyhPcqt77gei0UeaDq4J7V-=tMFYA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2023-09-05 16:07 ` Michal Koutný
2023-09-12 11:03 ` Michal Hocko
[not found] ` <20230831165611.2610118-1-yosryahmed-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2023-08-31 16:56 ` [PATCH v4 2/4] mm: memcg: add a helper for non-unified stats flushing Yosry Ahmed
[not found] ` <20230831165611.2610118-3-yosryahmed-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2023-09-04 14:45 ` Michal Hocko
2023-08-31 16:56 ` [PATCH v4 4/4] mm: memcg: use non-unified stats flushing for userspace reads Yosry Ahmed
[not found] ` <20230831165611.2610118-5-yosryahmed-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2023-09-04 15:15 ` Michal Hocko
[not found] ` <ZPX0kCKd4TaVLJY7-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2023-09-05 15:57 ` Yosry Ahmed
2023-09-08 0:52 ` Wei Xu
[not found] ` <CAAPL-u9D2b=iF5Lf_cRnKxUfkiEe0AMDTu6yhrUAzX0b6a6rDg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2023-09-08 1:02 ` Ivan Babrou
[not found] ` <CABWYdi1WNp9f20nRFEExn8QB1MwP7QXwvD6Q8xHHuTO2SUTLkA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2023-09-08 1:11 ` Yosry Ahmed
2023-09-11 13:11 ` Michal Hocko
2023-09-11 19:15 ` Wei Xu
2023-09-11 19:34 ` Michal Hocko
2023-09-11 20:01 ` Wei Xu
2023-09-11 20:21 ` Tejun Heo
2023-09-11 20:28 ` Yosry Ahmed
[not found] ` <ZP92xP5rdKdeps7Z-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2023-09-12 11:03 ` Michal Hocko
[not found] ` <ZQBFZMRL8WmqRgrM-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2023-09-12 11:09 ` Yosry Ahmed
2023-08-31 17:18 ` [PATCH v4 0/4] memcg: non-unified flushing for userspace stats Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZPX6luPGqypp68+L@dhcp22.suse.cz \
--to=mhocko-ibi9rg/b67k@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
--cc=ivan-lDpJ742SOEtZroRs9YW3xA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=mkoutny-IBi9RG/b67k@public.gmane.org \
--cc=muchun.song-fxUVXftIFDnyG1zEObXtfA@public.gmane.org \
--cc=roman.gushchin-fxUVXftIFDnyG1zEObXtfA@public.gmane.org \
--cc=shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=yosryahmed-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox