public inbox for cgroups@vger.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Luiz Capitulino <luizcap@amazon.com>
Cc: lizefan.x@bytedance.com, hannes@cmpxchg.org,
	cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
	longman@redhat.com, lcapitulino@gmail.com,
	"Michal Koutný" <mkoutny@suse.com>
Subject: Re: [PATH v2] cgroup: add cgroup_favordynmods= command-line option
Date: Mon, 18 Sep 2023 07:47:13 -1000	[thread overview]
Message-ID: <ZQiNIWQe7spOwjil@slm.duckdns.org> (raw)
In-Reply-To: <29bdb453-c6e3-a047-1f27-e9656da92301@amazon.com>

On Mon, Sep 18, 2023 at 10:01:13AM -0400, Luiz Capitulino wrote:
> 
> 
> On 2023-09-05 20:57, Luiz Capitulino wrote:
> > We have a need of using favordynmods with cgroup v1, which doesn't support
> > changing mount flags during remount. Enabling CONFIG_FAVOR_DYNMODS at
> > build-time is not an option because we want to be able to selectively
> > enable it for certain systems.
> > 
> > This commit addresses this by introducing the cgroup_favordynmods=
> > command-line option. This option works for both cgroup v1 and v2 and
> > also allows for disabling favorynmods when the kernel built with
> > CONFIG_FAVOR_DYNMODS=y.
> > 
> > Signed-off-by: Luiz Capitulino <luizcap@amazon.com>
> 
> Ping?

Michal raised some valid concerns. I don't really mind that it's not great
on the edges tho. Michal, what do you think?

Thanks.

-- 
tejun

  parent reply	other threads:[~2023-09-18 17:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-06  0:57 [PATH v2] cgroup: add cgroup_favordynmods= command-line option Luiz Capitulino
     [not found] ` <20230906005712.66461-1-luizcap-vV1OtcyAfmbQT0dZR+AlfA@public.gmane.org>
2023-09-06  1:53   ` Waiman Long
2023-09-06  6:58   ` Kamalesh Babulal
2023-09-06 12:59     ` Waiman Long
2023-09-07  9:51       ` [External] : " Kamalesh Babulal
2023-09-07 18:47         ` Luiz Capitulino
     [not found]           ` <e7675405-c910-340e-0679-0271dff76722-vV1OtcyAfmbQT0dZR+AlfA@public.gmane.org>
2023-09-08  7:04             ` Kamalesh Babulal
2023-09-07 15:06 ` Michal Koutný
2023-09-07 15:16   ` Luiz Capitulino
2023-09-07 15:57     ` Michal Koutný
2023-09-07 18:57       ` Luiz Capitulino
     [not found] ` <29bdb453-c6e3-a047-1f27-e9656da92301@amazon.com>
2023-09-18 17:47   ` Tejun Heo [this message]
     [not found]     ` <ZQiNIWQe7spOwjil-NiLfg/pYEd1N0TnZuCh8vA@public.gmane.org>
2023-09-19 11:00       ` Michal Koutný
2023-09-19 13:42         ` Luiz Capitulino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZQiNIWQe7spOwjil@slm.duckdns.org \
    --to=tj@kernel.org \
    --cc=cgroups@vger.kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=lcapitulino@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan.x@bytedance.com \
    --cc=longman@redhat.com \
    --cc=luizcap@amazon.com \
    --cc=mkoutny@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox