From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH] mm, memcg: expose swapcache stat for memcg v1 Date: Tue, 26 Sep 2023 00:29:57 -0700 Message-ID: References: <20230902100728.3850149-1-liushixin2@huawei.com> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=VB02rfAqrCwJrrIDo94dHomdWocZV8cYbgBNccAUQMk=; b=ETp0JudbYO6jWOHR8dt1yjNuuo ANXen3hdy7Mz22SUO98P7L9/e4iniE1lGCr1mPQXHUkSKDEIyC8GY8Su3mmKooq6UR8d6xFR85zcx //zTrG/P1LfB768hKeFtlJYLjY1/58D/ZAf3KCd5yCxzkYcLzfmAHHJvTw7e2NyONn1XN2fQJr2uK 1uTsOWjHzM8iM2ZucnmHgkM4qVJOq36oRA7/r5QB4Nrisp3bzJzsRfSdJd/TJhlS3ToCjWIUHuDxb tl+k39Lts3qdYVgNiAWcnvm4qw3dYglXtHRpPYpchgRBAglGDQn3Nc9zQA5wO31Lc1qe7EsvI8gd/ d3wjnD1g==; Content-Disposition: inline In-Reply-To: <20230902100728.3850149-1-liushixin2-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Liu Shixin Cc: Yosry Ahmed , Tejun Heo , Zefan Li , Johannes Weiner , Jonathan Corbet , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Kefeng Wang , Andrew Morton , cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org On Sat, Sep 02, 2023 at 06:07:28PM +0800, Liu Shixin wrote: > Since commit b6038942480e ("mm: memcg: add swapcache stat for memcg v2") > adds swapcache stat for the cgroup v2, it seems there is no reason to > hide it in memcg v1. Conversely, with swapcached it is more accurate to > evaluate the available memory for memcg. Why are we adding new features to the long deprecated cgroup v1? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7B6EE7D240 for ; Tue, 26 Sep 2023 07:30:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232684AbjIZHaS (ORCPT ); Tue, 26 Sep 2023 03:30:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231908AbjIZHaR (ORCPT ); Tue, 26 Sep 2023 03:30:17 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C103EDC; Tue, 26 Sep 2023 00:30:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=VB02rfAqrCwJrrIDo94dHomdWocZV8cYbgBNccAUQMk=; b=ETp0JudbYO6jWOHR8dt1yjNuuo ANXen3hdy7Mz22SUO98P7L9/e4iniE1lGCr1mPQXHUkSKDEIyC8GY8Su3mmKooq6UR8d6xFR85zcx //zTrG/P1LfB768hKeFtlJYLjY1/58D/ZAf3KCd5yCxzkYcLzfmAHHJvTw7e2NyONn1XN2fQJr2uK 1uTsOWjHzM8iM2ZucnmHgkM4qVJOq36oRA7/r5QB4Nrisp3bzJzsRfSdJd/TJhlS3ToCjWIUHuDxb tl+k39Lts3qdYVgNiAWcnvm4qw3dYglXtHRpPYpchgRBAglGDQn3Nc9zQA5wO31Lc1qe7EsvI8gd/ d3wjnD1g==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1ql2W5-00FnWf-1E; Tue, 26 Sep 2023 07:29:57 +0000 Date: Tue, 26 Sep 2023 00:29:57 -0700 From: Christoph Hellwig To: Liu Shixin Cc: Yosry Ahmed , Tejun Heo , Zefan Li , Johannes Weiner , Jonathan Corbet , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Kefeng Wang , Andrew Morton , cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm, memcg: expose swapcache stat for memcg v1 Message-ID: References: <20230902100728.3850149-1-liushixin2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230902100728.3850149-1-liushixin2@huawei.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: cgroups@vger.kernel.org Message-ID: <20230926072957.UhwbN0SkRSIzxPo_t_1Pg5lTcUfPMtQSY9Ww7rqZhAg@z> On Sat, Sep 02, 2023 at 06:07:28PM +0800, Liu Shixin wrote: > Since commit b6038942480e ("mm: memcg: add swapcache stat for memcg v2") > adds swapcache stat for the cgroup v2, it seems there is no reason to > hide it in memcg v1. Conversely, with swapcached it is more accurate to > evaluate the available memory for memcg. Why are we adding new features to the long deprecated cgroup v1?