From: Tejun Heo <tj@kernel.org>
To: Khazhismel Kumykov <khazhy@chromium.org>
Cc: Josef Bacik <josef@toxicpanda.com>, Jens Axboe <axboe@kernel.dk>,
Yu Kuai <yukuai3@huawei.com>,
cgroups@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, oleg@redhat.com,
linan122@huawei.com, Khazhismel Kumykov <khazhy@google.com>
Subject: Re: [PATCH] blk-throttle: check for overflow in calculate_bytes_allowed
Date: Fri, 20 Oct 2023 14:22:54 -1000 [thread overview]
Message-ID: <ZTMZ3nOXHyv73uvY@slm.duckdns.org> (raw)
In-Reply-To: <20231020223617.2739774-1-khazhy@google.com>
On Fri, Oct 20, 2023 at 03:36:17PM -0700, Khazhismel Kumykov wrote:
> Inexact, we may reject some not-overflowing values incorrectly, but
> they'll be on the order of exabytes allowed anyways.
>
> This fixes divide error crash on x86 if bps_limit is not configured or
> is set too high in the rare case that jiffy_elapsed is greater than HZ.
>
> Fixes: e8368b57c006 ("blk-throttle: use calculate_io/bytes_allowed() for throtl_trim_slice()")
> Fixes: 8d6bbaada2e0 ("blk-throttle: prevent overflow while calculating wait time")
> Signed-off-by: Khazhismel Kumykov <khazhy@google.com>
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
next prev parent reply other threads:[~2023-10-21 0:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 22:36 [PATCH] blk-throttle: check for overflow in calculate_bytes_allowed Khazhismel Kumykov
2023-10-21 0:22 ` Tejun Heo [this message]
2023-10-21 0:38 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTMZ3nOXHyv73uvY@slm.duckdns.org \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=josef@toxicpanda.com \
--cc=khazhy@chromium.org \
--cc=khazhy@google.com \
--cc=linan122@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox