From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="C7zkyBPN" Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83478194; Tue, 21 Nov 2023 08:20:10 -0800 (PST) Received: by mail-pf1-x42d.google.com with SMTP id d2e1a72fcca58-6c431b91b2aso4994857b3a.1; Tue, 21 Nov 2023 08:20:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700583610; x=1701188410; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=4fEN3R0r2mIA8xeTNMUf2/tu7fnJxweTIz/sq8uXz0Y=; b=C7zkyBPNKmwuqgdV6DlkAzWzyngAmAqomeDNGKsmvZB4+6MsbO/p8IMI5P9EQ59Tqq IVA9EKkJHFK1///SVIMHvmZ9C6SFgnKyRpAkp7QxnpBzCvYSKms0CeLWJvBucLeqDSJO uvgPqsVdWVlDuyfVll73UOnkMXSVGi9PN2FGn3kfFoLf+V6AyqW4fFoStfk1m4MVY5UJ AtG0cX4ue3vVV3boMuQ2WlXdp/p3/CNlPXRiud79cbW8x80lDRMN+qUfdPyDOlL6ImRm LyXAnssgTSkX/rnSk/2qoiUUpmm4oSdslj3BvvS9yUQh8CskWe69LtXnZPgx6tEW0NB/ 7IJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700583610; x=1701188410; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4fEN3R0r2mIA8xeTNMUf2/tu7fnJxweTIz/sq8uXz0Y=; b=GjAcM0Jrr6OzvzDaXTfIPayCuTx7kS0UGzPofyx0m7agrTn3tbeMqpX5HyqjEvZw8/ Mu6TCfaW+J9eC7+N024rwvwSgECV5zN9OaAa3otly65k1tp8IpQd5lPwF+zQTbdve2DS lly5fgd9Oso1zR8f8c6xYbXRQKX6o4lI8abAp1O7SroS0RbG558mfmyUdcNk+cX3VmvQ hBB12it8pLoc6Og6zFFmmmOSwhkogRSYQfiw8U7X1jf30SxOQ9hMDgjQvId/EbHm97dV AACvzTfo7sQCaf+hLROVJ13BoOj5ZpQWXcaNgQYar3DmBUpfswljb2rlddT1n/e+Yx+b uv/Q== X-Gm-Message-State: AOJu0YyhiAqx94t0lkQvK8B3CG0pvnXUi5mys1dB3P3O0S82izoYMfLj piM5YEy0rH7/gyy92huWtqE= X-Google-Smtp-Source: AGHT+IHEAIhmCRFUOCOZzpSgUheUQ/AOIGSm8yP1AKzyR/8fEl4T7UfNBCAMrwtsI1Cg3QtFnYw8lQ== X-Received: by 2002:a05:6a00:1390:b0:6cb:8abd:39ae with SMTP id t16-20020a056a00139000b006cb8abd39aemr6843335pfg.30.1700583609894; Tue, 21 Nov 2023 08:20:09 -0800 (PST) Received: from localhost (dhcp-72-253-202-210.hawaiiantel.net. [72.253.202.210]) by smtp.gmail.com with ESMTPSA id d13-20020a056a00244d00b006c3402c5442sm8087632pfj.84.2023.11.21.08.20.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Nov 2023 08:20:09 -0800 (PST) Sender: Tejun Heo Date: Tue, 21 Nov 2023 06:20:08 -1000 From: Tejun Heo To: Waiman Long Cc: Lai Jiangshan , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel test robot Subject: Re: [PATCH-cgroup] workqueue: Move workqueue_set_unbound_cpumask() and its helpers inside CONFIG_SYSFS Message-ID: References: <20231121021840.10937-1-longman@redhat.com> Precedence: bulk X-Mailing-List: cgroups@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231121021840.10937-1-longman@redhat.com> On Mon, Nov 20, 2023 at 09:18:40PM -0500, Waiman Long wrote: > Commit fe28f631fa94 ("workqueue: Add workqueue_unbound_exclude_cpumask() > to exclude CPUs from wq_unbound_cpumask") makes > workqueue_set_unbound_cpumask() static as it is not used elsewhere in > the kernel. However, this triggers a kernel test robot warning about > 'workqueue_set_unbound_cpumask' defined but not used when CONFIG_SYS > isn't defined. It happens that workqueue_set_unbound_cpumask() is only > called when CONFIG_SYS is defined. > > Move workqueue_set_unbound_cpumask() and its helpers inside the > CONFIG_SYSFS compilation block to avoid the warning. There is no > functional change. > > Fixes: fe28f631fa94 ("workqueue: Add workqueue_unbound_exclude_cpumask() to exclude CPUs from wq_unbound_cpumask") > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202311130831.uh0AoCd1-lkp@intel.com/ > Signed-off-by: Waiman Long Applied to cgroup/for-6.8. Thanks. -- tejun