public inbox for cgroups@vger.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Waiman Long <longman@redhat.com>
Cc: Zefan Li <lizefan.x@bytedance.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
	Mirsad Todorovac <mirsad.todorovac@alu.hr>
Subject: Re: [PATCH] cgroup/cpuset: Fix a memory leak in update_exclusive_cpumask()
Date: Wed, 28 Feb 2024 08:04:37 -1000	[thread overview]
Message-ID: <Zd91tagUX3EZCINk@slm.duckdns.org> (raw)
In-Reply-To: <20240228005801.429847-1-longman@redhat.com>

Hello,

On Tue, Feb 27, 2024 at 07:58:01PM -0500, Waiman Long wrote:
> Fix a possible memory leak in update_exclusive_cpumask() by moving the
> alloc_cpumasks() down after the validate_change() check which can fail
> and still before the temporary cpumasks are needed.
> 
> Fixes: e2ffe502ba45 ("cgroup/cpuset: Add cpuset.cpus.exclusive for v2")
> Reported-by: Mirsad Todorovac <mirsad.todorovac@alu.hr>
> Closes: https://lore.kernel.org/lkml/14915689-27a3-4cd8-80d2-9c30d0c768b6@alu.unizg.hr
> Signed-off-by: Waiman Long <longman@redhat.com>

Applied to cgroup/for-6.8-fixes with stable cc'd. Depending on when v6.9
gets cut, this might go in together with for-6.9 during rc1.

Thanks.

-- 
tejun

      parent reply	other threads:[~2024-02-28 18:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-28  0:58 [PATCH] cgroup/cpuset: Fix a memory leak in update_exclusive_cpumask() Waiman Long
2024-02-28 13:56 ` Mirsad Todorovac
2024-02-28 15:08   ` Waiman Long
2024-02-28 18:04 ` Tejun Heo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zd91tagUX3EZCINk@slm.duckdns.org \
    --to=tj@kernel.org \
    --cc=cgroups@vger.kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan.x@bytedance.com \
    --cc=longman@redhat.com \
    --cc=mirsad.todorovac@alu.hr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox