From: Tejun Heo <tj@kernel.org>
To: "Michal Koutný" <mkoutny@suse.com>
Cc: cgroups@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
Zefan Li <lizefan.x@bytedance.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Jonathan Corbet <corbet@lwn.net>, Shuah Khan <shuah@kernel.org>,
Muhammad Usama Anjum <usama.anjum@collabora.com>
Subject: Re: [PATCH v4 4/6] cgroup/pids: Add pids.events.local
Date: Tue, 16 Apr 2024 09:31:47 -1000 [thread overview]
Message-ID: <Zh7SI8LaSTEq4Bj4@slm.duckdns.org> (raw)
In-Reply-To: <20240416142014.27630-5-mkoutny@suse.com>
On Tue, Apr 16, 2024 at 04:20:12PM +0200, Michal Koutný wrote:
> struct cgroup_subsys pids_cgrp_subsys = {
> .css_alloc = pids_css_alloc,
> .css_free = pids_css_free,
> @@ -416,5 +469,6 @@ struct cgroup_subsys pids_cgrp_subsys = {
> .cancel_fork = pids_cancel_fork,
> .release = pids_release,
> .dfl_cftypes = pids_files,
> + .legacy_cftypes = pids_files_legacy,
Ah, you restore it here. I see what you're doing now. It may be better to
reorder patches so that .local is added first or just keep the legacy file
behavior temporarily altered than removing them altogether, but this isn't
the end of the world either. Can you please explicitly note what you're
doing in the commit message?
Thanks.
--
tejun
next prev parent reply other threads:[~2024-04-16 19:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-16 14:20 [PATCH v4 0/6] pids controller events rework Michal Koutný
2024-04-16 14:20 ` [PATCH v4 1/6] cgroup/pids: Remove superfluous zeroing Michal Koutný
2024-04-16 19:23 ` Tejun Heo
2024-04-16 14:20 ` [PATCH v4 2/6] cgroup/pids: Separate semantics of pids.events related to pids.max Michal Koutný
2024-04-16 19:27 ` Tejun Heo
2024-04-16 14:20 ` [PATCH v4 3/6] cgroup/pids: Make event counters hierarchical Michal Koutný
2024-04-16 14:20 ` [PATCH v4 4/6] cgroup/pids: Add pids.events.local Michal Koutný
2024-04-16 19:31 ` Tejun Heo [this message]
2024-04-16 14:20 ` [PATCH v4 5/6] selftests: cgroup: Lexicographic order in Makefile Michal Koutný
2024-04-16 14:20 ` [PATCH v4 6/6] selftests: cgroup: Add basic tests for pids controller Michal Koutný
2024-04-16 19:32 ` [PATCH v4 0/6] pids controller events rework Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zh7SI8LaSTEq4Bj4@slm.duckdns.org \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=hannes@cmpxchg.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=mkoutny@suse.com \
--cc=shuah@kernel.org \
--cc=usama.anjum@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox