Re: [PATCH 1/2] cgroup: Fix /proc/cgroups count for v2

T.J. Mercier
2024-05-28T23:02:51Z

On Tue, May 28, 2024 at 3:45 PM T.J. Mercier <tjmercier@google.com> wrote:
>
> On Tue, May 28, 2024 at 3:42 PM Tejun Heo <tj@kernel.org> wrote:
> >
> > On Tue, May 28, 2024 at 03:38:01PM -0700, T.J. Mercier wrote:
> > > > > I think it would make sense to introduce something in a similar
> > > > > fashion. Can't think of a good name off the top of my head but add a
> > > > > cgroup. file which lists the controllers in the subtree along with the
> > > > > number of css's.
> > > >
> > > > BTW, there is the 'debug' subsys that has (almost) exactly that:
> > > > 'debug.csses' -- it's in v1 fashion though so it won't show hierarchical
> > > > sums.
> >
> > Yeah, something like that but hierarchical and built into cgroup2 interface.
> > Would that work for your use case?
> >
> I think so, I'm checking this out now. debug as v1-only and non-stable
> interface files doesn't work, but the same sort of thing with a stable
> interface on v2 seems like it would.
>
Ok debug.cgroup_subsys_states reports css->css->online_cnt, but I'd
also want to include the number that are dying. Either as a separate
count or combined with the online_cnt like in /proc/cgroups.