From: Tejun Heo <tj@kernel.org>
To: "T.J. Mercier" <tjmercier@google.com>
Cc: "Michal Koutný" <mkoutny@suse.com>,
"Zefan Li" <lizefan.x@bytedance.com>,
"Johannes Weiner" <hannes@cmpxchg.org>,
shakeel.butt@linux.dev, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] cgroup: Fix /proc/cgroups count for v2
Date: Tue, 28 May 2024 12:41:30 -1000 [thread overview]
Message-ID: <ZlZdmlN3jpKbtgfN@slm.duckdns.org> (raw)
In-Reply-To: <CABdmKX1fPYjkA2S90NntVFjcoMRvQZY1FjHt780S6KZCsBSRJQ@mail.gmail.com>
Hello,
On Tue, May 28, 2024 at 03:38:07PM -0700, T.J. Mercier wrote:
> On Tue, May 28, 2024 at 3:30 PM Tejun Heo <tj@kernel.org> wrote:
> > > At the same time, the info provided currently is incorrect or at least
> > > misleading (when only v2 hierarchy is mounted, it mixes the counts) --
> > > that's what T.J.'s patch attempts to rectify in my understanding.
> >
> > Yeah, I was hoping to phase out that file once folks are all on v2.
>
> I'll buy a round of drinks when that happens, but aren't we a few
> years out from that? :)
I don't think we're too far off from at least making cgroup1 a CONFIG
option. As for the /proc/cgroups file, it's mostly useless on cgroup2, so I
was hoping that this could be put behind the same CONFIG option. I haven't
really thought through it tho, so it's not a hard set plan or anything.
Thanks.
--
tejun
next prev parent reply other threads:[~2024-05-28 22:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 16:37 [PATCH 1/2] cgroup: Fix /proc/cgroups count for v2 T.J. Mercier
2024-05-28 19:43 ` Tejun Heo
2024-05-28 21:42 ` Michal Koutný
2024-05-28 22:30 ` Tejun Heo
2024-05-28 22:38 ` T.J. Mercier
2024-05-28 22:41 ` Tejun Heo [this message]
2024-05-28 22:38 ` T.J. Mercier
2024-05-28 22:42 ` Tejun Heo
2024-05-28 22:45 ` T.J. Mercier
2024-05-28 23:02 ` T.J. Mercier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZlZdmlN3jpKbtgfN@slm.duckdns.org \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=mkoutny@suse.com \
--cc=shakeel.butt@linux.dev \
--cc=tjmercier@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox