From: Christoph Hellwig <hch@infradead.org>
To: Yu Kuai <yukuai1@huaweicloud.com>
Cc: Christoph Hellwig <hch@infradead.org>,
axboe@kernel.dk, tj@kernel.org, gregkh@linuxfoundation.org,
bvanassche@acm.org, josef@toxicpanda.com,
lizefan.x@bytedance.com, hannes@cmpxchg.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
cgroups@vger.kernel.org, yi.zhang@huawei.com,
yangerkun@huawei.com, "yukuai (C)" <yukuai3@huawei.com>
Subject: Re: [PATCH RFC v2 3/7] block: export some API
Date: Wed, 19 Jun 2024 23:48:20 -0700 [thread overview]
Message-ID: <ZnPQtJE8VqgPjaLA@infradead.org> (raw)
In-Reply-To: <25110963-cc9e-7c9f-09b3-d57e4ce6109b@huaweicloud.com>
On Tue, Jun 18, 2024 at 03:58:54PM +0800, Yu Kuai wrote:
> There is already bigger helper blkg_conf_prep() exported, as used by bfq
> for a long time already, and this helper is introduced for code
> optimization, as iocost configuration doesn't need to access the blkg.
>
> Perhaps this should be another discussion about "design mistakes",
> however, I'm not sure why. :( Do you have previous discussions?
blkg_conf_prep at least has some level of abstraction.
But at least my conclusion is: don't make blk-iocost modular. It's
far too messy to split out, and not really worth it.
next prev parent reply other threads:[~2024-06-20 6:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 3:17 [PATCH RFC v2 0/7] blk-iocost: support to build iocost as kernel module Yu Kuai
2024-06-18 3:17 ` [PATCH RFC v2 1/7] blk-cgroup: add a new helper pr_cont_blkg_path() Yu Kuai
2024-06-18 3:17 ` [PATCH RFC v2 2/7] cgroup: export cgroup_parse_float Yu Kuai
2024-06-18 3:17 ` [PATCH RFC v2 3/7] block: export some API Yu Kuai
2024-06-18 7:14 ` Christoph Hellwig
2024-06-18 7:58 ` Yu Kuai
2024-06-20 6:48 ` Christoph Hellwig [this message]
2024-06-18 3:17 ` [PATCH RFC v2 4/7] blk-iocost: factor out helpers to handle params from ioc_qos_write() Yu Kuai
2024-06-18 3:17 ` [PATCH RFC v2 5/7] blk-iocost: parse params before initializing iocost Yu Kuai
2024-06-18 3:17 ` [PATCH RFC v2 6/7] blk-iocost: support to free iocost Yu Kuai
2024-06-18 3:17 ` [PATCH RFC v2 7/7] blk-iocost: support to build iocost as kernel module Yu Kuai
2024-06-18 7:12 ` [PATCH RFC v2 0/7] " Christoph Hellwig
2024-06-18 8:03 ` Yu Kuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZnPQtJE8VqgPjaLA@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=cgroups@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hannes@cmpxchg.org \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=tj@kernel.org \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox