From: Tejun Heo <tj@kernel.org>
To: Waiman Long <longman@redhat.com>
Cc: Zefan Li <lizefan.x@bytedance.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Jonathan Corbet <corbet@lwn.net>,
cgroups@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
Kamalesh Babulal <kamalesh.babulal@oracle.com>,
Roman Gushchin <roman.gushchin@linux.dev>
Subject: Re: [PATCH v3 1/2] cgroup: Show # of subsystem CSSes in cgroup.stat
Date: Wed, 10 Jul 2024 11:59:10 -1000 [thread overview]
Message-ID: <Zo8ELsGOyFwkpKUj@slm.duckdns.org> (raw)
In-Reply-To: <20240710182353.2312025-1-longman@redhat.com>
Hello,
On Wed, Jul 10, 2024 at 02:23:52PM -0400, Waiman Long wrote:
> With this patch applied, a sample output from root cgroup.stat file
> was shown below.
>
> nr_descendants 54
> nr_dying_descendants 44
> nr_cpuset 1
> nr_cpu 40
> nr_io 40
> nr_memory 54
> nr_dying_memory 44
> nr_perf_event 55
> nr_hugetlb 1
> nr_pids 54
> nr_rdma 1
> nr_misc 1
So, css may be too specific a name but this looks a bit disorganized. How
about using controller as the common prefix? Maybe something like:
nr_controllers_cpu 40
nr_controllers_io 40
nr_controllers_memory 54
nr_controller_perf_event 55
...
nr_dying_controllers_memory 44
If controllers is too long, we can shorten it somehow or use subsys, maybe?
Thanks.
--
tejun
next prev parent reply other threads:[~2024-07-10 21:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-10 18:23 [PATCH v3 1/2] cgroup: Show # of subsystem CSSes in cgroup.stat Waiman Long
2024-07-10 18:23 ` [PATCH v3 2/2] cgroup: Limit frequency of reading cgroup.stat for unprivileged users Waiman Long
2024-07-10 21:43 ` [PATCH v3 1/2] cgroup: Show # of subsystem CSSes in cgroup.stat Roman Gushchin
2024-07-10 23:49 ` Waiman Long
2024-07-10 21:59 ` Tejun Heo [this message]
2024-07-10 23:51 ` Waiman Long
2024-07-11 13:49 ` Johannes Weiner
2024-07-11 14:05 ` Waiman Long
2024-07-11 17:18 ` Tejun Heo
2024-07-11 17:39 ` Waiman Long
2024-07-11 18:44 ` Tejun Heo
2024-07-11 18:51 ` Waiman Long
2024-07-11 18:59 ` Tejun Heo
2024-07-11 19:13 ` Waiman Long
2024-07-11 19:21 ` Tejun Heo
2024-07-11 19:29 ` Waiman Long
2024-07-11 19:59 ` Johannes Weiner
2024-07-11 21:00 ` Waiman Long
2024-07-11 21:57 ` Waiman Long
2024-07-12 16:29 ` Johannes Weiner
2024-07-12 17:10 ` Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zo8ELsGOyFwkpKUj@slm.duckdns.org \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=hannes@cmpxchg.org \
--cc=kamalesh.babulal@oracle.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=longman@redhat.com \
--cc=roman.gushchin@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox