From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48E032E40E for ; Mon, 22 Jul 2024 07:34:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721633698; cv=none; b=Pn81aY8TegbruQI79FbDr756fZD+WdgOK+R52B71C5GTXckL0yMUPRd6eiuxBx4RjYgm9U6XNO/NxnQFiNnvB0vT8g2OTGcLC8L8BqNFsIxmuanQWhk7cZrWgX0/xdVku/3RHAdibF+EfpLzqobxFs3M9q3IasVUmmBvp3WBPTo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721633698; c=relaxed/simple; bh=5I00kJ1IC/ju/fEuCiFmfghY0goYro6giF/Jc1eniek=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fy1h/tUxF/TMC//elU72p58ywLHrnzV1DIlYQz5sqt066+2BBOl9Mb/qKXAON5vF4g19kLl18RE6dlv7smfLKNXeZgJ0aywRIMb4hKAPyYLsHPrIfMHv2ybUJfX7HmJ0ZwYNZwjOajfjgTljExsSYB/3xG9HQCw1Er8G4ilFGXk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=N1XcTg8q; arc=none smtp.client-ip=209.85.218.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="N1XcTg8q" Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-a79a7d1a0dbso378552766b.2 for ; Mon, 22 Jul 2024 00:34:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1721633695; x=1722238495; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=LsvUE0o57OouoC7fjzRG0Fp0z7u/TQO/RaOGGl1k+XY=; b=N1XcTg8qKqLxBPl4sQSqBCCgBTTU5kbnOqQQaNlfv97AGdCdT9bVj4CHWghoOlRql8 OXgwuxOTvQm5b8yykLh21aeLTM+2JEJIar0/8bjcHwvcuSiA9X+/g431rMa1EtSXIYl2 wkR1/znkHM4e5cu9JEAPSX646W2OfWw4AhDCUy062WTpqn94stONf+nKNOEgmDvH4HO6 XkK6x/w/bNeFNzAjzG0L9nK6baMCS6IxrVFjdAMRRPikxEMLGt/+5c1vVQDGI0RjRU1t jH5m1RnDN+Jv/ywJxNUhD7XIVqkxDJNalHEPu+iKB12VZ+XmOMdWw1OJoshaKNpm5DyL Ydjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721633695; x=1722238495; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LsvUE0o57OouoC7fjzRG0Fp0z7u/TQO/RaOGGl1k+XY=; b=xRHg/L0tGe4ozbk2vvwj4SZbXlJaQRIF8n6rwq185SMU0hOmwXzDikOLjv8BMRSrlQ lSXsMffhn2Fc3AfjdxkbuSF9Ml4H//fnaWymui3OisqEl6icJP4rig36b6TstKylC7XZ cBm5Yxxbb3RuINsCMdMNQ6DABSuvsnrexOHx5IEiHcQs3NOl0ARo2npkFNWyGz025KUS ziLyXPjn4PbXwC9xaaU97bkFU5Th9Yc1m3a3z082i0modYt5UcqSqwz+ue96bBS7iW4w cSxPtyDlOAOfAAHhYBpJVL8yOjsV0gZ8mVuy9H7ba2rLhrlK3wDEA5tClDAZIItLI+XI yJMQ== X-Forwarded-Encrypted: i=1; AJvYcCWotmCysjOqIjthi0XI7Z+lKvkFqTFJLcKyyi8z/aWm5YCxWXqHvbF6kPI8yKV/p8pxGoFSxQ3gYjK2SlgNOQsXZ4ZkvMfrzQ== X-Gm-Message-State: AOJu0YwGBenaFK1C3jUwSH5CyYlQswl6ioEfiK5FgqhcgudscEVq67c0 XxeYeF+KvxsiaWE0sfKyH6V5GacwFfoqDL1zOvm39lYy+D5isFF8QY7lxKtR5CA= X-Google-Smtp-Source: AGHT+IEmWXROwHA87dq+wBT3GDAicPjakH0kJc74UbfmBRFfMAtxkJmSTHsiP8RgLPulsbfgFkyeVQ== X-Received: by 2002:a17:906:c142:b0:a77:dd5c:d7f4 with SMTP id a640c23a62f3a-a7a4bf39ab2mr351235466b.15.1721633694678; Mon, 22 Jul 2024 00:34:54 -0700 (PDT) Received: from localhost ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7a3c91e052sm384748366b.153.2024.07.22.00.34.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jul 2024 00:34:54 -0700 (PDT) Date: Mon, 22 Jul 2024 09:34:53 +0200 From: Michal Hocko To: Qu Wenruo Cc: Johannes Weiner , Qu Wenruo , linux-btrfs@vger.kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, cgroups@vger.kernel.org, linux-mm@kvack.org, Vlastimil Babka Subject: Re: [PATCH v7 2/3] btrfs: always uses root memcgroup for filemap_add_folio() Message-ID: References: <6a9ba2c8e70c7b5c4316404612f281a031f847da.1721384771.git.wqu@suse.com> <20240719170206.GA3242034@cmpxchg.org> <9202429f-e933-4212-a513-e065ba02517a@gmx.com> Precedence: bulk X-Mailing-List: cgroups@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9202429f-e933-4212-a513-e065ba02517a@gmx.com> On Sat 20-07-24 07:41:19, Qu Wenruo wrote: [...] > So according to the trend, I'm pretty sure VFS people will reject such > new interface just to skip accounting. I would just give it a try with your usecase described. If this is a nogo then the root cgroup workaround is still available. > Thus the GFP_NO_ACCOUNT solution looks more feasible. So we have GFP_ACCOUNT to opt in for accounting and now we should be adding GFP_NO_ACCOUNT to override it? This doesn't sound like a good use of gfp flags (which we do not have infinitely) and it is also quite confusing TBH. -- Michal Hocko SUSE Labs