From: Tejun Heo <tj@kernel.org>
To: Xiu Jianfeng <xiujianfeng@huawei.com>
Cc: josef@toxicpanda.com, axboe@kernel.dk, lizefan.x@bytedance.com,
hannes@cmpxchg.org, cgroups@vger.kernel.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] blk-cgroup: move congestion_count to struct blkcg
Date: Fri, 12 Jul 2024 07:19:46 -1000 [thread overview]
Message-ID: <ZpFlsrNMMUMnT_Lq@slm.duckdns.org> (raw)
In-Reply-To: <20240712085141.3288708-1-xiujianfeng@huawei.com>
Hello,
On Fri, Jul 12, 2024 at 08:51:41AM +0000, Xiu Jianfeng wrote:
> The congestion_count was introduced by commit d09d8df3a294 ("blkcg:
> add generic throttling mechanism"), but since it is closely related
> to the blkio subsys, it is not appropriate to put it in the struct
> cgroup, so move it to struct blkcg.
>
> Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
> ---
> only compiling tested
blkcg is per cgroup and blkg is per cgroup-device pair, so the change isn't
just moving the field but updating what it means and how it works. The
change needs a lot more thinking, justification and testing.
Thanks.
--
tejun
next prev parent reply other threads:[~2024-07-12 17:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-12 8:51 [PATCH -next] blk-cgroup: move congestion_count to struct blkcg Xiu Jianfeng
2024-07-12 17:19 ` Tejun Heo [this message]
2024-07-13 10:56 ` Yu Kuai
2024-07-13 17:35 ` Tejun Heo
2024-07-13 17:41 ` Tejun Heo
2024-07-15 12:35 ` xiujianfeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZpFlsrNMMUMnT_Lq@slm.duckdns.org \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=xiujianfeng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox