From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43EC01D551; Fri, 9 Aug 2024 20:06:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723233984; cv=none; b=DB1aHbHyCtQ1aZxepeztgJJOnS64hJAeL3khjMvlwniOTBuwwkAJ4FHsoi/0r81V1HGN/+ZSBJpd9maqAZrdwcLmwJz0jwRwIrlJUt6VRT9fzgQFFrxcukMbZpWy3kcsdlXQuRNJPzxSxb7/29emuUmovvM111OZuX6s1OeLffg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723233984; c=relaxed/simple; bh=mJdzdK8m5noSq0toiPWF7HbNribzPwd6/Nm7+l+vt8Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CfmCphRbJnmU7F9G3t22Ehm+q8wPjz3S1CDacW5veLNqTK1z+AdI7dC4IYVj+faUMnP625zF13DE0sMCbh+D0JRKIYREO8IU2iFl05eRs7uvTqvcINXJ0Vo+iAw8EcYfCs86woZR+yYTqzioItGySWvyQTfhktGeWqI3vyTMyjk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=gPDT8Gse; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="gPDT8Gse" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=dGa/8ZLokAbzEb+tPZ9uqejoZTdxPyVA0LUvs3W+vgQ=; b=gPDT8GseHd3nE2TMAodTAnIf5z HwKGNyCeucouDI8j0QOvSlHeQ61R2p6udfKuIvrmZRxOGphLXqFBffnj9CDP3icU7fLaUY7KW6JUD EEsr9PcVEvNLrBbpQIDHsrfybinmJOPPTQFsnZpON6htk8HnOfCkgKexF0WCXkk6Q7k0ShcljHE+3 8apRgvM9iLPQmINmzZf6WyyjLIN+ubmqS+1YaIA/J5nzAHgxtBoHWR7WnMuJoNWJR3PIduHGxoc6a EtWTkaFud/KB09W+ET/IZGeVVFlzeFj92D8GLSOKM/jlvl0ZwZc7wg9L08OyHBspf8YLt2dQyK6lx LGVAlcRg==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1scVsF-0000000B6dr-34eA; Fri, 09 Aug 2024 20:06:07 +0000 Date: Fri, 9 Aug 2024 21:06:07 +0100 From: Matthew Wilcox To: Shakeel Butt Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Meta kernel team , cgroups@vger.kernel.org Subject: Re: [PATCH] memcg: replace memcg ID idr with xarray Message-ID: References: <20240809172618.2946790-1-shakeel.butt@linux.dev> Precedence: bulk X-Mailing-List: cgroups@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240809172618.2946790-1-shakeel.butt@linux.dev> On Fri, Aug 09, 2024 at 10:26:18AM -0700, Shakeel Butt wrote: > At the moment memcg IDs are managed through IDR which requires external > synchronization mechanisms and makes the allocation code a bit awkward. > Let's switch to xarray and make the code simpler. > > Suggested-by: Matthew Wilcox > Signed-off-by: Shakeel Butt Looks great. Reviewed-by: Matthew Wilcox (Oracle)