From: Tejun Heo <tj@kernel.org>
To: Waiman Long <longman@redhat.com>
Cc: "Zefan Li" <lizefan.x@bytedance.com>,
"Johannes Weiner" <hannes@cmpxchg.org>,
"Michal Koutný" <mkoutny@suse.com>,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
"Roman Gushchin" <roman.gushchin@linux.dev>,
"Kamalesh Babulal" <kamalesh.babulal@oracle.com>
Subject: Re: [PATCH] cgroup: Fix incorrect WARN_ON_ONCE() in css_release_work_fn()
Date: Fri, 9 Aug 2024 06:36:21 -1000 [thread overview]
Message-ID: <ZrZFhe-teNE6xAKn@slm.duckdns.org> (raw)
In-Reply-To: <20240809032259.1233679-1-longman@redhat.com>
On Thu, Aug 08, 2024 at 11:22:59PM -0400, Waiman Long wrote:
> It turns out that the WARN_ON_ONCE() call in css_release_work_fn
> introduced by commit ab0312526867 ("cgroup: Show # of subsystem CSSes
> in cgroup.stat") is incorrect. Although css->nr_descendants must be
> 0 when a css is released and ready to be freed, the corresponding
> cgrp->nr_dying_subsys[ss->id] may not be 0 if a subsystem is activated
> and deactivated multiple times with one or more of its previous
> activation leaving behind dying csses.
>
> Fix the incorrect warning by removing the cgrp->nr_dying_subsys check.
>
> Fixes: ab0312526867 ("cgroup: Show # of subsystem CSSes in cgroup.stat")
> Closes: https://lore.kernel.org/cgroups/6f301773-2fce-4602-a391-8af7ef00b2fb@redhat.com/T/#t
> Signed-off-by: Waiman Long <longman@redhat.com>
Applied to cgroup/for-6.12.
Thanks.
--
tejun
prev parent reply other threads:[~2024-08-09 16:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-09 3:22 [PATCH] cgroup: Fix incorrect WARN_ON_ONCE() in css_release_work_fn() Waiman Long
2024-08-09 16:36 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZrZFhe-teNE6xAKn@slm.duckdns.org \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kamalesh.babulal@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=longman@redhat.com \
--cc=mkoutny@suse.com \
--cc=roman.gushchin@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox