From: Tejun Heo <tj@kernel.org>
To: Joshua Hahn <joshua.hahnjy@gmail.com>
Cc: cgroups@vger.kernel.org, hannes@cmpxchg.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
lizefan.x@bytedance.com, mkoutny@suse.com, shuah@kernel.org
Subject: Re: [PATCH v2 1/2] Tracking cgroup-level niced CPU time
Date: Fri, 30 Aug 2024 09:41:40 -1000 [thread overview]
Message-ID: <ZtIgdEt9RSU4MCIP@slm.duckdns.org> (raw)
In-Reply-To: <20240830141939.723729-2-joshua.hahnjy@gmail.com>
On Fri, Aug 30, 2024 at 07:19:38AM -0700, Joshua Hahn wrote:
> From: Joshua Hahn <joshua.hahn6@gmail.com>
>
> Cgroup-level CPU statistics currently include time spent on
> user/system processes, but do not include niced CPU time (despite
> already being tracked). This patch exposes niced CPU time to the
> userspace, allowing users to get a better understanding of their
> hardware limits and can facilitate more informed workload distribution.
>
> A new field 'ntime' is added to struct cgroup_base_stat as opposed to
> struct task_cputime to minimize footprint.
Patch looks fine to me but can you please do the followings?
- Add subsystem prefix to the patch titles. Look other commits for examples.
- Add Signed-off-by to both.
Thanks.
--
tejun
next prev parent reply other threads:[~2024-08-30 19:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-30 14:19 [PATCH v2 0/2] Exposing nice CPU usage to userspace Joshua Hahn
2024-08-30 14:19 ` [PATCH v2 1/2] Tracking cgroup-level niced CPU time Joshua Hahn
2024-08-30 19:41 ` Tejun Heo [this message]
2024-08-30 20:06 ` Joshua Hahn
2024-08-30 14:19 ` [PATCH v2 2/2] Selftests for niced CPU statistics Joshua Hahn
2024-09-02 15:45 ` [PATCH v2 0/2] Exposing nice CPU usage to userspace Michal Koutný
2024-09-10 21:01 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZtIgdEt9RSU4MCIP@slm.duckdns.org \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=joshua.hahnjy@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=mkoutny@suse.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox