From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A77CB635 for ; Wed, 4 Sep 2024 04:38:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725424741; cv=none; b=USkV27hMM1khCLF76L7EdQlJuQnFrtYJMH95tKjpffBZLzLU0nr+DvMBbbg3ez2mQ5/MqcLBA4Mtx7PX+inKe5bHExW15wy7Mnhsz+os8t6PZU/jTK3cxaAhYNpePFLDE6sDD9BBcX1zkSLezDxvfzdWxrRCNK1IpEclYFrKrqc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725424741; c=relaxed/simple; bh=x9qDFWxMO96K95WfPtNrQiI5WrN0j5yTvSTJ5hJKH7Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UcYgj0kGknJRtyHoOrBDDMgaEoQUNL7CxBtZE8FCI0vqoVswSuwMuPuLUuJ5oHPYsfzg6uQGCjbE9rgkmIWPEt0vhqIEl+14UDir6uNKFNhpbQFOEgLYGU0UTbO3jRk9D+2Ot9aA9pnGzQ/Ft74FNKFMjpt1ffRzt8J7EpSBb0w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=I0eeaew+; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="I0eeaew+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725424738; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3zsKB3WdrmMbEpvlPWbs3HIFo2lGSqwqj8i5jKNJQ5U=; b=I0eeaew+MBP/mW0E0GCUUhPtlLO/OPiIa32sg8Jm39Iq0mib9yzaM82uZWiaVujmgqh/2c h1NJIIRHbc6bMcCbkRSNpFVD1IJR0t8VU8gogz9bQgKUugEiuyVoAEVrTiSPyRMukYjLM9 K1BwiWoFdga6NHXjV7eIiZgaDjRSf60= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-583-npusVDDyNsWTrMLS-6XdPA-1; Wed, 04 Sep 2024 00:38:57 -0400 X-MC-Unique: npusVDDyNsWTrMLS-6XdPA-1 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DCBDA19560A3; Wed, 4 Sep 2024 04:38:53 +0000 (UTC) Received: from fedora (unknown [10.72.116.130]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 537E6195605A; Wed, 4 Sep 2024 04:38:44 +0000 (UTC) Date: Wed, 4 Sep 2024 12:38:39 +0800 From: Ming Lei To: Yu Kuai Cc: Jens Axboe , jack@suse.cz, tj@kernel.org, josef@toxicpanda.com, paolo.valente@unimore.it, mauro.andreolini@unimore.it, avanzini.arianna@gmail.com, cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, yi.zhang@huawei.com, yangerkun@huawei.com, "yukuai (C)" Subject: Re: [PATCH for-6.12 0/4] block, bfq: fix corner cases related to bfqq merging Message-ID: References: <20240902130329.3787024-1-yukuai1@huaweicloud.com> <2ee05037-fb4f-4697-958b-46f0ae7d9cdd@kernel.dk> Precedence: bulk X-Mailing-List: cgroups@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 On Wed, Sep 04, 2024 at 09:32:26AM +0800, Yu Kuai wrote: > Hi, > > 在 2024/09/03 23:51, Jens Axboe 写道: > > On 9/2/24 7:03 AM, Yu Kuai wrote: > > > From: Yu Kuai > > > > > > Our syzkaller report a UAF problem(details in patch 1), however it can't > > > be reporduced. And this set are some corner cases fix that might be > > > related, and they are found by code review. > > > > > > Yu Kuai (4): > > > block, bfq: fix possible UAF for bfqq->bic with merge chain > > > block, bfq: choose the last bfqq from merge chain in > > > bfq_setup_cooperator() > > > block, bfq: don't break merge chain in bfq_split_bfqq() > > > block, bfq: use bfq_reassign_last_bfqq() in bfq_bfqq_move() > > > > > > block/bfq-cgroup.c | 7 +------ > > > block/bfq-iosched.c | 17 +++++++++++------ > > > block/bfq-iosched.h | 2 ++ > > > 3 files changed, 14 insertions(+), 12 deletions(-) > > > > BFQ is effectively unmaintained, and has been for quite a while at > > this point. I'll apply these, thanks for looking into it, but I think we > > should move BFQ to an unmaintained state at this point. > > Sorry to hear that, we would be willing to take on the responsibility of > maintaining this code, please let me know if there are any specific > guidelines or processes we should follow. We do have customers are using > bfq in downstream kernels, and we are still running lots of test for > bfq. Hi Yukuai, BTW, BFQ is default IO scheduler for SCSI/MMC in Fedora. That is great if you'd like to volunteer to take over maintaining it. thanks, Ming