From: Tejun Heo <tj@kernel.org>
To: "Michal Koutný" <mkoutny@suse.com>
Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, Zefan Li <lizefan.x@bytedance.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Shakeel Butt <shakeel.butt@linux.dev>,
Muchun Song <muchun.song@linux.dev>,
Andrew Morton <akpm@linux-foundation.org>,
Chen Ridong <chenridong@huawei.com>
Subject: Re: [PATCH 3/4] cgroup: Disallow mounting v1 hierarchies without controller implementation
Date: Tue, 10 Sep 2024 10:03:57 -1000 [thread overview]
Message-ID: <ZuCmLXMLQd7xMs06@slm.duckdns.org> (raw)
In-Reply-To: <20240909163223.3693529-4-mkoutny@suse.com>
On Mon, Sep 09, 2024 at 06:32:22PM +0200, Michal Koutný wrote:
> The configs that disable some v1 controllers would still allow mounting
> them but with no controller-specific files. (Making such hierarchies
> equivalent to named v1 hierarchies.) To achieve behavior consistent with
> actual out-compilation of a whole controller, the mounts should treat
> respective controllers as non-existent.
>
> Wrap implementation into a helper function, leverage legacy_files to
> detect compiled out controllers. The effect is that mounts on v1 would
> fail and produce a message like:
> [ 1543.999081] cgroup: Unknown subsys name 'memory'
>
> Signed-off-by: Michal Koutný <mkoutny@suse.com>
Applied to cgroup/for-6.12.
Thanks.
--
tejun
next prev parent reply other threads:[~2024-09-10 20:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-09 16:32 [PATCH 0/4] Followups to controllers' v1 compilation Michal Koutný
2024-09-09 16:32 ` [PATCH 1/4] memcg: Cleanup with !CONFIG_MEMCG_V1 Michal Koutný
2024-09-09 17:35 ` Shakeel Butt
2024-09-10 20:05 ` Tejun Heo
2024-09-10 20:19 ` Andrew Morton
2024-09-10 20:40 ` Tejun Heo
2024-09-09 16:32 ` [PATCH 2/4] cgroup/cpuset: Expose cpuset filesystem with cpuset v1 only Michal Koutný
2024-09-09 17:07 ` Waiman Long
2024-09-10 20:02 ` Tejun Heo
2024-09-09 16:32 ` [PATCH 3/4] cgroup: Disallow mounting v1 hierarchies without controller implementation Michal Koutný
2024-09-10 20:03 ` Tejun Heo [this message]
2024-09-09 16:32 ` [PATCH 4/4] cgroup: Do not report unavailable v1 controllers in /proc/cgroups Michal Koutný
2024-09-09 17:11 ` Waiman Long
2024-09-10 20:04 ` Tejun Heo
2025-07-09 18:22 ` Ben Hutchings
2025-07-11 13:10 ` Michal Koutný
2025-07-11 22:15 ` Tejun Heo
2025-07-18 9:18 ` Michal Koutný
2025-07-19 16:18 ` Tejun Heo
2025-07-12 9:28 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZuCmLXMLQd7xMs06@slm.duckdns.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=chenridong@huawei.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizefan.x@bytedance.com \
--cc=mhocko@kernel.org \
--cc=mkoutny@suse.com \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).