Linux cgroups development
 help / color / mirror / Atom feed
From: Juri Lelli <juri.lelli@redhat.com>
To: Phil Auld <pauld@redhat.com>
Cc: Waiman Long <longman@redhat.com>, Tejun Heo <tj@kernel.org>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Michal Koutny <mkoutny@suse.com>, Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
	Valentin Schneider <vschneid@redhat.com>,
	Qais Yousef <qyousef@layalina.io>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	"Joel Fernandes (Google)" <joel@joelfernandes.org>,
	Suleiman Souhlal <suleiman@google.com>,
	Aashish Sharma <shraash@google.com>,
	Shin Kawamura <kawasin@google.com>,
	Vineeth Remanan Pillai <vineeth@bitbyteword.org>,
	linux-kernel@vger.kernel.org, cgroups@vger.kernel.org
Subject: Re: [PATCH 2/2] sched/deadline: Correctly account for allocated bandwidth during hotplug
Date: Wed, 13 Nov 2024 14:58:37 +0000	[thread overview]
Message-ID: <ZzS-ncIOnEgrOlte@jlelli-thinkpadt14gen4.remote.csb> (raw)
In-Reply-To: <20241113134908.GB402105@pauld.westford.csb>

Hi Phil,

On 13/11/24 08:49, Phil Auld wrote:
> 
> Hi Juri,
> 
> On Wed, Nov 13, 2024 at 12:57:23PM +0000 Juri Lelli wrote:
> > For hotplug operations, DEADLINE needs to check that there is still enough
> > bandwidth left after removing the CPU that is going offline. We however
> > fail to do so currently.
> > 
> > Restore the correct behavior by restructuring dl_bw_manage() a bit, so
> > that overflow conditions (not enough bandwidth left) are properly
> > checked. Also account for dl_server bandwidth, i.e. discount such
> > bandwidht in the calculation since NORMAL tasks will be anyway moved
> 
> "bandwidth"  :)

Grrrr. :)

> 
> 
> > away from the CPU as a result of the hotplug operation.
> >
> 
> LGTM.
> 
> Reviewed-by: Phil Auld <pauld@redhat.com>

Thanks!
Juri


  reply	other threads:[~2024-11-13 14:58 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-13 12:57 [PATCH 0/2] Fix DEADLINE bandwidth accounting in root domain changes and hotplug Juri Lelli
2024-11-13 12:57 ` [PATCH 1/2] sched/deadline: Restore dl_server bandwidth on non-destructive root domain changes Juri Lelli
2024-11-13 13:43   ` Phil Auld
2024-11-13 14:57     ` Juri Lelli
2024-11-13 16:00   ` Waiman Long
2024-11-17  0:54   ` Joel Fernandes
2024-11-13 12:57 ` [PATCH 2/2] sched/deadline: Correctly account for allocated bandwidth during hotplug Juri Lelli
2024-11-13 13:49   ` Phil Auld
2024-11-13 14:58     ` Juri Lelli [this message]
2024-11-13 16:22       ` Phil Auld
2024-11-13 16:06   ` Waiman Long
2024-11-13 16:40     ` Juri Lelli
2024-11-13 16:42       ` Waiman Long
2024-11-13 16:50         ` Waiman Long
2024-11-13 18:11           ` Juri Lelli
2024-11-13 18:19             ` Waiman Long

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZzS-ncIOnEgrOlte@jlelli-thinkpadt14gen4.remote.csb \
    --to=juri.lelli@redhat.com \
    --cc=bigeasy@linutronix.de \
    --cc=bsegall@google.com \
    --cc=cgroups@vger.kernel.org \
    --cc=dietmar.eggemann@arm.com \
    --cc=hannes@cmpxchg.org \
    --cc=joel@joelfernandes.org \
    --cc=kawasin@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=longman@redhat.com \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=mkoutny@suse.com \
    --cc=pauld@redhat.com \
    --cc=peterz@infradead.org \
    --cc=qyousef@layalina.io \
    --cc=rostedt@goodmis.org \
    --cc=shraash@google.com \
    --cc=suleiman@google.com \
    --cc=tj@kernel.org \
    --cc=vincent.guittot@linaro.org \
    --cc=vineeth@bitbyteword.org \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox