From mboxrd@z Thu Jan 1 00:00:00 1970 From: Waiman Long Subject: Re: [PATCH v2 1/6] cgroup/cpuset: Rename functions dealing with DEADLINE accounting Date: Wed, 3 May 2023 13:54:26 -0400 Message-ID: References: <20230503072228.115707-1-juri.lelli@redhat.com> <20230503072228.115707-2-juri.lelli@redhat.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683136476; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cKPUL7FZWA4e+itJ2WAtXLunhkYaY3Bk3M9ZOMdUVpQ=; b=hbM85wjG5OqYg/6yF//dDtyBCiqICqD/YvlKsnu2vkIU53VC4mr/94yTYdIqe8adof3ILw JnLfoPEMHfzb8S9I9q9Vlb3+wXIK5eaq+RWYMDqaZPUAFO2BsdOQ2MSYRjqPvMkmr5FyLQ GpHV8Cmq0jxDbEmuSUBTIGwsh7eBmCE= Content-Language: en-US In-Reply-To: <20230503072228.115707-2-juri.lelli-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Juri Lelli , Peter Zijlstra , Ingo Molnar , Qais Yousef , Tejun Heo , Zefan Li , Johannes Weiner , Hao Luo Cc: Dietmar Eggemann , Steven Rostedt , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, luca.abeni-5rdYK369eBLQB0XuIGIEkQ@public.gmane.org, claudio-YOzL5CV4y4YG1A2ADO40+w@public.gmane.org, tommaso.cucinotta-5rdYK369eBLQB0XuIGIEkQ@public.gmane.org, bristot-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, mathieu.poirier-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Vincent Guittot , Wei Wang , Rick Yiu , Quentin Perret , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Sudeep Holla On 5/3/23 03:22, Juri Lelli wrote: > rebuild_root_domains() and update_tasks_root_domain() have neutral > names, but actually deal with DEADLINE bandwidth accounting. > > Rename them to use 'dl_' prefix so that intent is more clear. > > No functional change. > > Suggested-by: Qais Yousef > Signed-off-by: Juri Lelli > --- > kernel/cgroup/cpuset.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c > index e4ca2dd2b764..428ab46291e2 100644 > --- a/kernel/cgroup/cpuset.c > +++ b/kernel/cgroup/cpuset.c > @@ -1066,7 +1066,7 @@ static int generate_sched_domains(cpumask_var_t **domains, > return ndoms; > } > > -static void update_tasks_root_domain(struct cpuset *cs) > +static void dl_update_tasks_root_domain(struct cpuset *cs) > { > struct css_task_iter it; > struct task_struct *task; > @@ -1079,7 +1079,7 @@ static void update_tasks_root_domain(struct cpuset *cs) > css_task_iter_end(&it); > } > > -static void rebuild_root_domains(void) > +static void dl_rebuild_rd_accounting(void) > { > struct cpuset *cs = NULL; > struct cgroup_subsys_state *pos_css; > @@ -1107,7 +1107,7 @@ static void rebuild_root_domains(void) > > rcu_read_unlock(); > > - update_tasks_root_domain(cs); > + dl_update_tasks_root_domain(cs); > > rcu_read_lock(); > css_put(&cs->css); > @@ -1121,7 +1121,7 @@ partition_and_rebuild_sched_domains(int ndoms_new, cpumask_var_t doms_new[], > { > mutex_lock(&sched_domains_mutex); > partition_sched_domains_locked(ndoms_new, doms_new, dattr_new); > - rebuild_root_domains(); > + dl_rebuild_rd_accounting(); > mutex_unlock(&sched_domains_mutex); > } > Reviewed-by: Waiman Long