Re: [PATCH v3 2/2] vmscan,cgroup: apply mems_effective to reclaim

[Gregory Price <gourry@gourry.net>]

On Sat, Apr 19, 2025 at 08:31:41PM -0400, Waiman Long wrote:
> On 4/19/25 1:38 AM, Gregory Price wrote:
> > diff --git a/include/linux/cpuset.h b/include/linux/cpuset.h
> > index 893a4c340d48..c64b4a174456 100644
> > --- a/include/linux/cpuset.h
> > +++ b/include/linux/cpuset.h
> > @@ -171,6 +171,7 @@ static inline void set_mems_allowed(nodemask_t nodemask)
> >   	task_unlock(current);
> >   }
> > +extern bool cpuset_node_allowed(struct cgroup *cgroup, int nid);
> >   #else /* !CONFIG_CPUSETS */
> >   static inline bool cpusets_enabled(void) { return false; }
> > @@ -282,6 +283,10 @@ static inline bool read_mems_allowed_retry(unsigned int seq)
> >   	return false;
> >   }
> > +static inline bool cpuset_node_allowed(struct cgroup *cgroup, int nid)
> > +{
> > +	return false;
> > +}
> >   #endif /* !CONFIG_CPUSETS */
> 
> I suppose we should return true in the !CONFIG_CPUSETS case.
> 
> Other than that, the patch looks good to me.
> 

Woop, quite right, thanks.

I'll v4 and hopefully get some -mm feedback

~Gregory