cgroups.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Shashank Balaji <shashank.mahadasyam@sony.com>
Cc: "Johannes Weiner" <hannes@cmpxchg.org>,
	"Michal Koutný" <mkoutny@suse.com>,
	"Jonathan Corbet" <corbet@lwn.net>,
	cgroups@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	"Shinya Takumi" <shinya.takumi@sony.com>
Subject: Re: [PATCH v2 3/3] cgroup, docs: cpu controller interaction with various scheduling policies
Date: Wed, 21 May 2025 07:31:35 -1000	[thread overview]
Message-ID: <aC4N9z0MuTLC2lf0@slm.duckdns.org> (raw)
In-Reply-To: <aC2Fl4DVRbn6bS8H@JPC00244420>

On Wed, May 21, 2025 at 04:49:43PM +0900, Shashank Balaji wrote:
> > > +Note that the ``cgroup_*`` family of callbacks require ``CONFIG_EXT_GROUP_SCHED``

CONFIG_EXT_GROUP_SCHED is auto-enabled if CONFIG_SCHED_CLASS_EXT and
CONFIG_CGROUP_SCHED are enabled, so no need to mention it explicitly.

> > > +to be enabled. For each of the following interface files, the above categories
> > > +will be referred to. All time durations are in microseconds.
> > 
> > Can we document the above in sched_ext documentation and point to it from
> > here? Documenting sched_ext details here seems a bit out of place and prone
> > to becoming stale over time.
> 
> Got it. Apart from that, is the content alright? 

Other than the above, yeah, looks correct to me.

Thanks.

-- 
tejun

      reply	other threads:[~2025-05-21 17:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-20 14:07 [PATCH v2 0/3] cgroup, docs: cpu controller interaction with various scheduling policies Shashank Balaji via B4 Relay
2025-05-20 14:07 ` [PATCH v2 1/3] cgroup, docs: be specific about bandwidth control of rt processes Shashank Balaji via B4 Relay
2025-05-20 20:11   ` Tejun Heo
2025-05-21  1:14     ` Shashank.Mahadasyam
2025-05-21 16:30       ` Tejun Heo
2025-05-21 16:35   ` Tejun Heo
2025-05-20 14:07 ` [PATCH v2 2/3] sched_ext, docs: add label Shashank Balaji via B4 Relay
2025-05-20 20:26   ` Tejun Heo
2025-05-20 14:07 ` [PATCH v2 3/3] cgroup, docs: cpu controller interaction with various scheduling policies Shashank Balaji via B4 Relay
2025-05-20 20:16   ` Tejun Heo
2025-05-21  7:49     ` Shashank Balaji
2025-05-21 17:31       ` Tejun Heo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aC4N9z0MuTLC2lf0@slm.duckdns.org \
    --to=tj@kernel.org \
    --cc=cgroups@vger.kernel.org \
    --cc=corbet@lwn.net \
    --cc=hannes@cmpxchg.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkoutny@suse.com \
    --cc=shashank.mahadasyam@sony.com \
    --cc=shinya.takumi@sony.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).