Linux cgroups development
 help / color / mirror / Atom feed
From: Wei Gao <wegao@suse.com>
To: "Michal Koutný" <mkoutny@suse.com>
Cc: Petr Vorel <pvorel@suse.cz>,
	ltp@lists.linux.it, Li Wang <liwang@redhat.com>,
	cgroups@vger.kernel.org
Subject: Re: [LTP] [PATCH v1] sched_rr_get_interval01.c: Put test process into absolute root cgroup (0::/)
Date: Sat, 7 Jun 2025 14:42:22 -0400	[thread overview]
Message-ID: <aESIDuS42cY_sLBe@MiWiFi-CR6608-srv> (raw)
In-Reply-To: <orzx7vfokvwuceowwjctea4yvujn75djunyhsqvdfr5bw7kqe7@rkn5tlnzwllu>

On Thu, Jun 05, 2025 at 05:56:11PM +0200, Michal Koutný wrote:
> On Thu, Jun 05, 2025 at 11:40:19AM +0200, Petr Vorel <pvorel@suse.cz> wrote:
> > @Michal @Li WDYT?
> 
> RT_GROUP scheduling is v1 feature as of now.
> 
> Testing cgroup v2 makes only sense with 
> CONFIG_RT_GROUP_SCHED=y and CONFIG_RT_GROUP_SCHED_DEFAULT_DISABLED=y
> (this combination is equivalent to CONFIG_RT_GROUP_SCHED=n on v2).

@Michal Koutný  So we should skip test cgroupv2 with CONFIG_RT_GROUP_SCHED=yes, correct? Like following change?

diff --git a/testcases/kernel/syscalls/sched_rr_get_interval/sched_rr_get_interval01.c b/testcases/kernel/syscalls/sched_rr_get_interval/sched_rr_get_interval01.c
index 55516ec89..b12bd7857 100644
--- a/testcases/kernel/syscalls/sched_rr_get_interval/sched_rr_get_interval01.c
+++ b/testcases/kernel/syscalls/sched_rr_get_interval/sched_rr_get_interval01.c
@@ -43,10 +43,9 @@ static void setup(void)

        tp.type = tv->ts_type;

+       static const char * const kconf[] = {"CONFIG_RT_GROUP_SCHED=y", NULL};
+       if ((access("/sys/fs/cgroup/cgroup.controllers", F_OK) == 0) && !tst_kconfig_check(kconf_strict)) {
+               tst_brk(TCONF, "CONFIG_RT_GROUP_SCHED not support on cgroupv2");
+       }

> 
> HTH,
> Michal



  reply	other threads:[~2025-06-07  6:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20250605142943.229010-1-wegao@suse.com>
2025-06-05  9:40 ` [LTP] [PATCH v1] sched_rr_get_interval01.c: Put test process into absolute root cgroup (0::/) Petr Vorel
2025-06-05 11:17   ` Andrea Cervesato
2025-06-05 15:56   ` Michal Koutný
2025-06-07 18:42     ` Wei Gao [this message]
2025-06-09 11:44       ` Michal Koutný
2025-06-09 13:33         ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aESIDuS42cY_sLBe@MiWiFi-CR6608-srv \
    --to=wegao@suse.com \
    --cc=cgroups@vger.kernel.org \
    --cc=liwang@redhat.com \
    --cc=ltp@lists.linux.it \
    --cc=mkoutny@suse.com \
    --cc=pvorel@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox