From: Tejun Heo <tj@kernel.org>
To: Jemmy Wong <jemmywong512@gmail.com>
Cc: "Michal Koutný" <mkoutny@suse.com>,
"Johannes Weiner" <hannes@cmpxchg.org>,
"Waiman Long" <longman@redhat.com>,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 0/3] cgroup: Add lock guard support
Date: Mon, 9 Jun 2025 06:34:42 -1000 [thread overview]
Message-ID: <aEcNIvp4TcGUXUmD@slm.duckdns.org> (raw)
In-Reply-To: <20250606161841.44354-1-jemmywong512@gmail.com>
On Sat, Jun 07, 2025 at 12:18:38AM +0800, Jemmy Wong wrote:
> v1 changes:
> - remove guard support for BPF
> - split patch into parts
>
> v0 link:
> https://lore.kernel.org/all/20250605211053.19200-1-jemmywong512@gmail.com/
>
> Jemmy Wong (3):
> cgroup: add lock guard support for cgroup_muetx
> cgroup: add lock guard support for css_set_lock and rcu
> cgroup: add lock guard support for others
So, I'm rather ambivalent about this patchset but leaning towards not
applying them. The lock guards are fine but I'm not sure what converting the
existing code base wholesale buys us. We're already pretty good at detecting
locking problems with lockdep and all and the code being modified hasn't
seen significant locking changes in ages. There are no practical benefits to
converting the code base at this point.
Thanks.
--
tejun
next prev parent reply other threads:[~2025-06-09 16:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-06 16:18 [PATCH v1 0/3] cgroup: Add lock guard support Jemmy Wong
2025-06-06 16:18 ` [PATCH v1 1/3] cgroup: add lock guard support for cgroup_muetx Jemmy Wong
2025-06-17 9:09 ` Michal Koutný
2025-06-06 16:18 ` [PATCH v1 2/3] cgroup: add lock guard support for css_set_lock and rcu Jemmy Wong
2025-06-17 9:09 ` Michal Koutný
2025-06-06 16:18 ` [PATCH v1 3/3] cgroup: add lock guard support for others Jemmy Wong
2025-06-07 10:50 ` kernel test robot
2025-06-08 8:52 ` Jemmy Wong
2025-06-17 9:10 ` Michal Koutný
2025-06-09 16:34 ` Tejun Heo [this message]
2025-06-17 9:08 ` [PATCH v1 0/3] cgroup: Add lock guard support Michal Koutný
2025-06-20 10:45 ` Jemmy Wong
2025-06-21 2:52 ` Tejun Heo
2025-06-23 14:03 ` Johannes Weiner
2025-06-30 17:39 ` Michal Koutný
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aEcNIvp4TcGUXUmD@slm.duckdns.org \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=jemmywong512@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mkoutny@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).