From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A1131A08CA for ; Tue, 16 Sep 2025 13:40:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758030018; cv=none; b=Xg7Qn94tgVtUADbUHsg78LsJhRhyAmPusrWYg68moe2D7MdMKHxzK1DuKzzJEXjxKNKHeK37cFBIuQ93sl9BkpOdoHHJ7JsJX0JKkfCwQ2cASwlJKO+4I7s8+lOw6orJ/DiCgHuFWd+DQgwgsM1p9ie5AUwjfliZYsJzCAyiHqs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758030018; c=relaxed/simple; bh=+gio5aL+IW3u8W8SSU4aBeYKAREDBl4pvtVMTW2Fww4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nHvgI2JA3bGgczJ0XgrSx7MYfB96isfY/I1E7MfsMsXjoLXZSeW0++q2glKRpJ+SPKkWD7SG8SJ4ObL5+F5uQ5mSeXQQnw7d8OmBu4Mb04etKS8fs29tXKORx88+cM7ELnIKLDJr2wQBwLW+mm/+H8mUDUs4kk0IqXlsHYTRdY4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=w11yYXx+; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="w11yYXx+" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-3e8ea11a325so3683628f8f.1 for ; Tue, 16 Sep 2025 06:40:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1758030015; x=1758634815; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=mcfExlni0fgEhBakaF+iv8wUB2vTkCFI57QVuCuRuQI=; b=w11yYXx+PJ2S70aQQE6th1BIImCh6AeKdDLfGNuw5UKqoUlQg24eqiqWzz2LuG36Rr St7GLc6KvVp/2vysYpx1BN3l0cAXG/8+P9e80zbhvu/Kg7OAgIdQCFEeLjhmwiKxH+uf p7ihY0EUmz0EaHqBp8WcDF9zuLuLyQk+vBrXeBBCcAVU8+lRgrLuFbvDVAgOIpnGq/Qi TVC8MIaj7CrgWSh+klvGhsiNYl/1fjByc8yKuEVjD/sDV2EDFt/ZzKKNRqEpI7ky3nTm IhtAJC8awvvIPShrMU6xonUvljn1ALrGtZTid0edYRLBXDT+vBY0Tfbmur/QuBe+zHRM wSpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758030015; x=1758634815; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mcfExlni0fgEhBakaF+iv8wUB2vTkCFI57QVuCuRuQI=; b=w1kap9U+kAIBmKzvGXndgnS8Pz4s1pTiODXCBLo2qlbvOlpx/RadxasYJhy/SHiu9K 204quwEWRE+FagzDbwY0faaP+Ft7nM0k5/84VeABb/btgbZ6lEF3XfDoQAdJFIXIVjpn PGdJcww61lb7wi9QxVcNiDo98hawRvU7UKf6U829DfkHGftiLdVQE0u016MvxllvHe8G tElK7bRTXTcCpBC9tYLAV3lSgGMYmYB15jEsF/J/VUAH5ZxFZ9eDSBq27AUQWYDZ0nkK BlMsCwkDpax7J2hzEW2zylSqq5amqaCIBGMkdmk91PthcIEIMrPSmZFDhrBfCTuWrOQo 101Q== X-Forwarded-Encrypted: i=1; AJvYcCUzkrXYQdA40CwWYGO06PGZkszw0pLTbi6B0BbAbgKw85n7qCyj3wU8eQJwvhGXVY01w7g8N9uC@vger.kernel.org X-Gm-Message-State: AOJu0Yw+bL9yrGkhRsUhLGupHHE7PD5boXy84LyldxlBd9HTqJgwAGeF 09HITKtnwqf8YU50FjqYyOCYPWqDLxRBgmnLsuQLEe0anjRjCrTl2tmpHccCoMa9OyI= X-Gm-Gg: ASbGnctl23gwmbkUBhblcdIFrZYIHQ0UkSyqdFHGjwRIawt2z9ebKrfCSAYYiyXK2X/ rg0j54kr5uOa+C9YCKISpoT27ktLX8KkfKbLz1+cEldqa+1oAiuTKxqAnT0j5nQ24tOA7rWuczk lxPOqn013NepSElfwTfwKhErKQc8H2nm4hQq3KsaAXn1aNY+990vIZJmlMgHDqKQltygYq8aQuA QodVLaArAHl812S9ZYaSmlOdm/+wE3IF/nWpHeoSuImCUEj/DojqJW5rRJSw2+JrAuH10FGwUCa OC/xR0FvK8mzcNhYIXRt3c6lZ9MyFMeM1e2QERHDvzWl5Qy+GKvHKISTKUJW9TJUlA9OuZtPfQL ylcjQorYa1wpDIHPoqiwEWRLPnIY= X-Google-Smtp-Source: AGHT+IG8kaWPMWFHbVd4viKfQeFJBGjRKwC9gr1w5fiYvRQ3T/k+ZTU4DWIxru8SYExw4YHgKkL4Vg== X-Received: by 2002:a05:6000:2887:b0:3ec:dbcc:8104 with SMTP id ffacd0b85a97d-3ecdbcc8195mr912496f8f.36.1758030014747; Tue, 16 Sep 2025 06:40:14 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-45f31c51e8dsm41553405e9.1.2025.09.16.06.40.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Sep 2025 06:40:14 -0700 (PDT) Date: Tue, 16 Sep 2025 16:40:10 +0300 From: Dan Carpenter To: Mark Brown Cc: Christian Brauner , Jan Kara , Amir Goldstein , linux-fsdevel@vger.kernel.org, Josef Bacik , Jeff Layton , Mike Yuan , Zbigniew =?utf-8?Q?J=C4=99drzejewski-Szmek?= , Lennart Poettering , Daan De Meyer , Aleksa Sarai , Alexander Viro , Jens Axboe , Tejun Heo , Johannes Weiner , Michal =?iso-8859-1?Q?Koutn=FD?= , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Chuck Lever , linux-nfs@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v2 04/33] block: use extensible_ioctl_valid() Message-ID: References: <20250912-work-namespace-v2-0-1a247645cef5@kernel.org> <20250912-work-namespace-v2-4-1a247645cef5@kernel.org> <02da33e3-6583-4344-892f-a9784b9c5b1b@sirena.org.uk> Precedence: bulk X-Mailing-List: cgroups@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <02da33e3-6583-4344-892f-a9784b9c5b1b@sirena.org.uk> Yeah, the: if (extensible_ioctl_valid(cmd, FS_IOC_GETLBMD_CAP, LBMD_SIZE_VER0)) return -ENOIOCTLCMD; test is inverted... It should be if (!valid) return instead of if (valid) return; regards, dan carpenter