From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 081F5199931 for ; Tue, 14 Oct 2025 08:15:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760429750; cv=none; b=KVKO44/swwOSIrwRb5dJa+Ou0BSgdrM58CGI8iYWy3Yej9A138KG4DcsGXhfiWqXRzUx+V2Y5C38gLXty16hgv+UDZrxV6dfhH6ucqFfRWzSGqgVdTD4ZM6btXB13j4yXf/cyfd2cm6dk1pruvNwXbL6T4bbFHClHrTlT78493E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760429750; c=relaxed/simple; bh=T3VM9+nJOucKbcAUNaLY7AnPZybT97dyUiiCrlM3Of4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YDGimCDL1eZKHAgKJD/6G9nzs0zXISVXlVzmQr8BsQpNo9sVNJCbtBINOJmDfYl7WXcnAp+MHno3w3dcmLp1UqRKxKvwvU3j1Aj1dGBMZntMTxs3gCQ4Lr81gPqGFkBxqL/hRXCGQf5IrF6awMP5OPJPyQz7l0v/bHXPzq9XG5k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=cdiu2Tfd; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="cdiu2Tfd" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1760429747; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CRy/NLeLP/eFxKeQw3E8oGP9HZl94Z/4n7yWShfTFEg=; b=cdiu2Tfd88q3TGIL24fLx1nj6TUzlE8I9yUb9dpQQp3QTh4GA0QIAC7PeNcwaf6PIST6Sx A3hAa8PgLVH93a3X4jmXDRf34dHYfPA5uR0ESKfMYFvYoN5I/J5lNWgKxmjB1ccrPoMvc8 H7G8EyNF0Zl1yjG86MJye9WyEoxEE0U= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-578-a295BwRoPSuqjrnzznlUcw-1; Tue, 14 Oct 2025 04:15:44 -0400 X-MC-Unique: a295BwRoPSuqjrnzznlUcw-1 X-Mimecast-MFC-AGG-ID: a295BwRoPSuqjrnzznlUcw_1760429742 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 716781800577; Tue, 14 Oct 2025 08:15:42 +0000 (UTC) Received: from fedora (unknown [10.72.120.30]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4AFEB1955F21; Tue, 14 Oct 2025 08:15:34 +0000 (UTC) Date: Tue, 14 Oct 2025 16:15:29 +0800 From: Ming Lei To: Yu Kuai Cc: nilay@linux.ibm.com, tj@kernel.org, josef@toxicpanda.com, axboe@kernel.dk, cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, yukuai1@huaweicloud.com, yi.zhang@huawei.com, yangerkun@huawei.com, johnny.chenyi@huawei.com Subject: Re: [PATCH 4/4] blk-mq-debugfs: make blk_mq_debugfs_register_rqos() static Message-ID: References: <20251014022149.947800-1-yukuai3@huawei.com> <20251014022149.947800-5-yukuai3@huawei.com> Precedence: bulk X-Mailing-List: cgroups@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251014022149.947800-5-yukuai3@huawei.com> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 On Tue, Oct 14, 2025 at 10:21:49AM +0800, Yu Kuai wrote: > Because it's only used inside blk-mq-debugfs.c now. If it is true, why do you export it in 2nd patch? Thanks, Ming