Re: [PATCH 1/2] selftests: cgroup: add values_close_assert helper

[Tejun Heo <tj@kernel.org>]

Hello,

On Tue, Oct 14, 2025 at 04:31:50PM +0200, Sebastian Chlad wrote:
> +/*
> + * Checks if two given values differ by less than err% of their sum and assert
> + * with detailed debug info if not.
> + */
> +static inline int values_close_assert(long a, long b, int err)

I wonder whether assert is a bit misleading given that asserts are generally
expected to terminate the program on failure. Maybe sth like
values_close_verbose() or values_close_report()?

> +{
> +	long diff  = labs(a - b);
> +	long limit = (a + b) / 100 * err;
> +	double actual_err = (a + b) ? (100.0 * diff / (a + b)) : 0.0;
> +	int close = diff <= limit;
> +
> +	if (!close) {
> +		fprintf(stderr,
> +			"[FAIL] actual=%ld expected=%ld | diff=%ld | limit=%ld | "
> +			"tolerance=%d%% | actual_error=%.2f%%\n",
> +			a, b, diff, limit, err, actual_err);
> +	}

{} are unnecessary here. Can you please drop them?

Thanks.

-- 
tejun