From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF7592ECE8C for ; Wed, 8 Oct 2025 09:43:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759916610; cv=none; b=NDTvUzkBGc+K2hLcGIpaiOjpzjWGHgxd78mRebgiocdM9gM/XFCM1bdHKOxoVfNb69emuUq5wt2P+nQIAS/chR8Wbl8pRr2mbDT8+kgVWu8ZV2I2gZ2pS8WfyTcUssoKXfS6dfpoVUNo29h8PnYCZua3WIPsX06sIvHcskjr4nU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759916610; c=relaxed/simple; bh=UTW5mtv7Lyr9/eDXszw01FGvctILLITZPcdY0ymNFqg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ssMJc24nnVFKhlAE1vIsYG5pgAQ2VK/eYkfNzUQ1QIuJi9FQZaw3A6nilKhK9D7VJ6bIDS+EO7/M/xxUZNlHygqWpISIO4So+qe8BRpcW8NBu3USkQ/HAl58F14zI1rWX+qi2ptkfIo5PMNjkQS0AQ/x9Z7l9LG6VEuY4XUWvw8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=FiRw7aLo; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="FiRw7aLo" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759916607; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ru66GWqBbf75/3gN0RGafI2ekfutqLRJQg30YGzf8Nc=; b=FiRw7aLouzZ/7mvPr0p+ZZClU56/l1OAhG4yivlIkG4xoY9p4WYM0sGadG4ul+F2IzRFeE mnwXp3grdC/DtuE+f55urHlUqnf7zK/DtvQyyKDlCLYuw21pgWahYYOOb00smLuIXs4omr Y4ylJFCCxi/dfjYols5yarfbZ5gj0OM= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-682-TjFin79PMK-Hpoi7soQNuQ-1; Wed, 08 Oct 2025 05:43:25 -0400 X-MC-Unique: TjFin79PMK-Hpoi7soQNuQ-1 X-Mimecast-MFC-AGG-ID: TjFin79PMK-Hpoi7soQNuQ_1759916604 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-46e7a2c3773so3142605e9.0 for ; Wed, 08 Oct 2025 02:43:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759916604; x=1760521404; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ru66GWqBbf75/3gN0RGafI2ekfutqLRJQg30YGzf8Nc=; b=RRwHMLvXdCCyU4uDYQQx9c4s0GUvnNJZKfbyrKDuZ2StcUBpMDHlUFjKG1pQXgSoCE 37c+Byde5NaflkX+ENiDeOABysiZeIkGXotcLPvL0FultWd26eJa+Tmzy3X1onlCSvQf XMEdRugBkrLcE6uZYrL/d7ZFUZkigcRTeFH5EpLUINZq/32wdON7PEeuaT3rhaGn2r1v FjEaeIjp/xa5rDVp8wCJQhMzp8oyIGmrXRi8/9pl2+p9/wwhcO6myL+TXMcqlPj4P9Of YUOD69HhrxkjGkO2Rvz4gxcSb6pkWlcsbGJQhUwNb39axzyaSqbVA5WD3dfKVyi02JtK r5sQ== X-Forwarded-Encrypted: i=1; AJvYcCVXx+X1x/IaA3GhBXE9DneM7sVzbw9OR0sxbka+0WBl3+YOcGYWPe0MaTT58W5/COIfV2kh4TqM@vger.kernel.org X-Gm-Message-State: AOJu0YwpTSFCH9EZzHiExGZlLz+DEo0BDx5RxeBGSTc6B8jmJlALXH43 kpZAtlBjT5MBxkjL4Do0kmc1DRlhcx/2dKF8MTGJcmzUXYLw//6bwWm9pYGmZJDHvo3NQpuJlX3 YDMDC2azeGA70eaExTEVmVT9YVPkzsJ4hDhWMKX+5x5Kh+/cRGisMVKC6rho= X-Gm-Gg: ASbGncvhpYUh65ae2KjoQ91s5VOwR372NsKBVH1ChOPHNMMhKnL45LDd9lTeGoN/qi8 jJHGK/tHeXWZWxw7wfhEC0dLfwn41UfPrLNzzjToxPmtqMxXRKE4hmRcnmJNmo3V4PAYRxtDygU FyRS+RG3SJ7ItF2/EOGCbol1JsZ8Hg/fftWqMEZ8x5tv2tcW34F5MRmZtxT/i4sbT23lME2Qxut tJXx63SMXy985LDnq3qdoa/j1RW7nPXz++2p14J+amf7s64d3fTD8+I3g5ZqRnXrBMVRqVRAm47 5VvPqRs+Lq1k6ElCNw0QIpKvSIbfjL4PvX3RypHcmqXdK/00c89+hLBRkGTFG7iKQ48akvz+geg qdw== X-Received: by 2002:a05:6000:310b:b0:3d3:b30:4cf2 with SMTP id ffacd0b85a97d-4266e7beaa3mr1451507f8f.19.1759916604378; Wed, 08 Oct 2025 02:43:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE9rUnK+CzKM3Tge7L83s/7DmaOGIMKz5YVjnXrE4Jnj285Du60+ERNzF+vGaZ3ET1i00K20g== X-Received: by 2002:a05:6000:310b:b0:3d3:b30:4cf2 with SMTP id ffacd0b85a97d-4266e7beaa3mr1451484f8f.19.1759916603909; Wed, 08 Oct 2025 02:43:23 -0700 (PDT) Received: from jlelli-thinkpadt14gen4.remote.csb ([176.206.13.103]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4255d8f01a0sm28969251f8f.48.2025.10.08.02.43.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Oct 2025 02:43:23 -0700 (PDT) Date: Wed, 8 Oct 2025 11:43:21 +0200 From: Juri Lelli To: Greg Kroah-Hartman Cc: Peter Zijlstra , tj@kernel.org, linux-kernel@vger.kernel.org, mingo@kernel.org, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, longman@redhat.com, hannes@cmpxchg.org, mkoutny@suse.com, void@manifault.com, arighi@nvidia.com, changwoo@igalia.com, cgroups@vger.kernel.org, sched-ext@lists.linux.dev, liuwenfang@honor.com, tglx@linutronix.de Subject: Re: [PATCH 10/12] sched: Add locking comments to sched_class methods Message-ID: References: <20251006104402.946760805@infradead.org> <20251006104527.694841522@infradead.org> <20251008070419.GR4067720@noisy.programming.kicks-ass.net> <2025100822-drained-foe-2426@gregkh> Precedence: bulk X-Mailing-List: cgroups@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2025100822-drained-foe-2426@gregkh> On 08/10/25 09:33, Greg Kroah-Hartman wrote: > On Wed, Oct 08, 2025 at 09:04:19AM +0200, Peter Zijlstra wrote: > > On Tue, Oct 07, 2025 at 11:54:18AM +0200, Juri Lelli wrote: > > > > > Not for this patch, but I wondered if, while we are at it, we wanted to > > > complete documentation of these flags. My new AI friend is suggesting > > > the following, is it very much garbage? :) > > > > Heh; its not terrible. I've been playing with local LLMs, but mostly > > I've found they struggle with getting enough context to not be utterly > > demented. And when you up the context window, they get unusable slow :/ > > > > Setting up and configuring the whole pile of subtly interlocking stacks > > of software to get anything useful out of this stuff is non-trivial (it > > reminds me of the sendmail m4 days). > > > > > --- > > > > > > From: Claude > > > Date: Mon, 7 Oct 2025 12:44:13 +0200 > > > Subject: sched: Document remaining DEQUEUE/ENQUEUE flags > > > > > > Complete the flag documentation by adding descriptions for the three > > > previously undocumented flags: DEQUEUE_SPECIAL, DEQUEUE_THROTTLE, and > > > ENQUEUE_INITIAL. > > > > > > DEQUEUE_SPECIAL is used when dequeuing tasks in special states (stopped, > > > traced, parked, dead, or frozen) that don't use the normal wait-loop > > > pattern and must not use delayed dequeue. > > > > > > DEQUEUE_THROTTLE is used when removing tasks from the runqueue due to > > > CFS bandwidth throttling, preventing delayed dequeue to ensure proper > > > throttling behavior. > > > > > > ENQUEUE_INITIAL is used when enqueueing newly created tasks in > > > wake_up_new_task(), allowing the fair scheduler to give them preferential > > > initial placement (half vslice when PLACE_DEADLINE_INITIAL is enabled). > > > > > > Signed-off-by: Claude > > > Not-so-sure-yet: Juri Lelli > > > > Is this the generally acceptable form of attribution for these things? > > I'm not sure what the official guidance is on using these AI tools. > > > > Greg, you have any insights here? > > First off, Claude can NOT sign off on anything, so that's a non-starter. > All Red Hat people should know that :) Yep, knew that. But I felt guilty nontheless as I didn't touch the change at all. Current SoB was kind of a (silly) joke. :) > Otherwise, there is a draft of something that was going to address stuff > like this floating around by Dave Hansen, I'll go poke him to see what > the status of that is. I believe it was suggested something like Co-developed-by: and then Signed-off-by: , but indeed curious to know how that discussion ended. Thanks! Juri