Re: [PATCH v2 07/23] mm: introduce bpf_oom_kill_process() bpf kfunc

Michal Hocko
2025-10-31T09:06:01Z

On Mon 27-10-25 16:17:10, Roman Gushchin wrote:
> Introduce bpf_oom_kill_process() bpf kfunc, which is supposed
> to be used by BPF OOM programs. It allows to kill a process
> in exactly the same way the OOM killer does: using the OOM reaper,
> bumping corresponding memcg and global statistics, respecting
> memory.oom.group etc.
>
> On success, it sets om_control's bpf_memory_freed field to true,
> enabling the bpf program to bypass the kernel OOM killer.
>
> Signed-off-by: Roman Gushchin <roman.gushchin@linux.dev>

LGTM
Just a minor question

> + /* paired with put_task_struct() in oom_kill_process() */
> + task = tryget_task_struct(task);

Any reason this is not a plain get_task_struct?
--
Michal Hocko
SUSE Labs