From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 018AC214812; Wed, 5 Nov 2025 15:23:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762356184; cv=none; b=gVdJ3zCzAn/kvoWEuxLzgohdApoKM+0vevvpTX5piYXFyho5cI90vrgCY9BCNnsiLnqy/TOdhVA9ENVvrOkditB9NklhoLPZ0N+t3FY8+Zxb7c1CDhO8ZPfASvP93dDDYi8pD3a07OxbJqHsKnaCmhcwCHt0eW6IYI8jfSNNCzg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762356184; c=relaxed/simple; bh=fusB0gibvJKJQXePl8CXgegfMzOrPm+adEItFF8rn4g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=htytefE4YnDrCTZsTOMuTQmyODYqZ9jrBR2hKhuETlRa1iqQrnGG0y4YPZq8Yi+CKriz1k0+uDMyoJBEcHowa7HMHRNwdCCarkoGsmPBVQ/yJheU3ba2F0r6+l3iZiZR3c8fDh12rBDym/d18gYPSGYtKwkUf0x7o1hqeyH4EZ4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fI54FeAi; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fI54FeAi" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5CEDBC4CEF5; Wed, 5 Nov 2025 15:23:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1762356183; bh=fusB0gibvJKJQXePl8CXgegfMzOrPm+adEItFF8rn4g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fI54FeAijnMRfBlbxLG2+Iek1ya9gdrVicMOy6ppH48QNJY1JwCA0YIcMTsGcAyyZ KuEb2RQHhUEh749M7gs858+NV46mLYZbGP/8Mp4QmoJ81PcA4BX5I+j9kHoraKETyY 5/xsZ+pDWMBJe6yrYwpFs/GuyQIvd/XVyzYLrl689vn8XudarKTwU0ZOlC8B+b3wxA 4M04j8KUlHVMArmw92JUAxOG0ooE93fYnwL/Ap60WXkOAbqG1sxhteuwbYCz02ush8 Nel4ht9ZvEnSBScs7Jx0YygYSCSf5Dvon/HzaCuHFaOaiCZMR0DrRHFWElXp1YaKVm 4kzXv9mqOHBdg== Date: Wed, 5 Nov 2025 16:23:01 +0100 From: Frederic Weisbecker To: Waiman Long Cc: LKML , Michal =?iso-8859-1?Q?Koutn=FD?= , Andrew Morton , Bjorn Helgaas , Catalin Marinas , Danilo Krummrich , "David S . Miller" , Eric Dumazet , Gabriele Monaco , Greg Kroah-Hartman , Ingo Molnar , Jakub Kicinski , Jens Axboe , Johannes Weiner , Lai Jiangshan , Marco Crivellari , Michal Hocko , Muchun Song , Paolo Abeni , Peter Zijlstra , Phil Auld , "Rafael J . Wysocki" , Roman Gushchin , Shakeel Butt , Simon Horman , Tejun Heo , Thomas Gleixner , Vlastimil Babka , Will Deacon , cgroups@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-block@vger.kernel.org, linux-mm@kvack.org, linux-pci@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 12/33] sched/isolation: Convert housekeeping cpumasks to rcu pointers Message-ID: References: <20251013203146.10162-1-frederic@kernel.org> <20251013203146.10162-13-frederic@kernel.org> <083388fb-3240-4329-ad49-b81cd89acffd@redhat.com> Precedence: bulk X-Mailing-List: cgroups@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <083388fb-3240-4329-ad49-b81cd89acffd@redhat.com> Le Mon, Oct 20, 2025 at 11:49:53PM -0400, Waiman Long a écrit : > > bool housekeeping_test_cpu(int cpu, enum hk_type type) > > { > > - if (static_branch_unlikely(&housekeeping_overridden)) > > - if (housekeeping.flags & BIT(type)) > > - return cpumask_test_cpu(cpu, housekeeping.cpumasks[type]); > > + if (housekeeping.flags & BIT(type)) > > + return cpumask_test_cpu(cpu, housekeeping_cpumask(type)); > > return true; > > } > > The housekeeping_overridden static key check is kept in other places except > this one. Should we keep it for consistency? Indeed! Thanks. -- Frederic Weisbecker SUSE Labs